From: Helmut Grohne <helmut@...divi.de>
Subject: [PATCH v3] CVE-2022-45142: gsskrb5: fix accidental logic inversions

The referenced commit attempted to fix miscompilations with gcc-9 and
gcc-10 by changing `memcmp(...)` to `memcmp(...) != 0`. Unfortunately,
it also inverted the result of the comparison in two occasions. This
inversion happened during backporting the patch to 7.7.1 and 7.8.0.

Fixes: f6edaafcfefd ("gsskrb5: CVE-2022-3437 Use constant-time memcmp()
 for arcfour unwrap")
Signed-off-by: Helmut Grohne <helmut@...divi.de>
---
 lib/gssapi/krb5/arcfour.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Changes since v1:
 * Fix typo in commit message.
 * Mention 7.8.0 in commit message. Thanks to Jeffrey Altman.

Changes since v2:
 * Add CVE identifier.

NB (Felix Lechner): The message above and the patch below were taken from the
disclosure here: https://www.openwall.com/lists/oss-security/2023/02/08/1

diff --git a/lib/gssapi/krb5/arcfour.c b/lib/gssapi/krb5/arcfour.c
index e838d007a..eee6ad72f 100644
--- a/lib/gssapi/krb5/arcfour.c
+++ b/lib/gssapi/krb5/arcfour.c
@@ -365,7 +365,7 @@ _gssapi_verify_mic_arcfour(OM_uint32 * minor_status,
 	return GSS_S_FAILURE;
     }

-    cmp = (ct_memcmp(cksum_data, p + 8, 8) == 0);
+    cmp = (ct_memcmp(cksum_data, p + 8, 8) != 0);
     if (cmp) {
 	*minor_status = 0;
 	return GSS_S_BAD_MIC;
@@ -730,7 +730,7 @@ OM_uint32 _gssapi_unwrap_arcfour(OM_uint32 *minor_status,
 	return GSS_S_FAILURE;
     }

-    cmp = (ct_memcmp(cksum_data, p0 + 16, 8) == 0); /* SGN_CKSUM */
+    cmp = (ct_memcmp(cksum_data, p0 + 16, 8) != 0); /* SGN_CKSUM */
     if (cmp) {
 	_gsskrb5_release_buffer(minor_status, output_message_buffer);
 	*minor_status = 0;
--
2.38.1
 class='right' method='get' action='/guix/log/gnu/packages/patches/gd-Revert-fix-303-gdlib.pc.patch'>
<input type='hidden' name='id' value='820bf78cbc487d28457acc6cb790f4cbd7cc49b9'/><select name='qt'>
<option value='grep'>log msg</option>
<option value='author'>author</option>
<option value='committer'>committer</option>
<option value='range'>range</option>
</select>
<input class='txt' type='search' size='10' name='q' value=''/>
<input type='submit' value='search'/>
</form>
</td></tr></table>
<div class='path'>path: <a href='/guix/log/?id=820bf78cbc487d28457acc6cb790f4cbd7cc49b9'>root</a>/<a href='/guix/log/gnu?id=820bf78cbc487d28457acc6cb790f4cbd7cc49b9'>gnu</a>/<a href='/guix/log/gnu/packages?id=820bf78cbc487d28457acc6cb790f4cbd7cc49b9'>packages</a>/<a href='/guix/log/gnu/packages/patches?id=820bf78cbc487d28457acc6cb790f4cbd7cc49b9'>patches</a>/<a href='/guix/log/gnu/packages/patches/gd-Revert-fix-303-gdlib.pc.patch?id=820bf78cbc487d28457acc6cb790f4cbd7cc49b9'>gd-Revert-fix-303-gdlib.pc.patch</a></div><div class='content'><table class='list nowrap'><tr class='nohover'><th class='left'>Age</th><th class='left'>Commit message (<a href='/guix/log/gnu/packages/patches/gd-Revert-fix-303-gdlib.pc.patch?id=820bf78cbc487d28457acc6cb790f4cbd7cc49b9&amp;showmsg=1'>Expand</a>)</th><th class='left'>Author</th></tr>
<tr><td><span title='2021-11-14 16:36:58 -0800'>2021-11-14</span></td><td><a href='/guix/commit/gnu/packages/patches/gd-Revert-fix-303-gdlib.pc.patch?id=6cdf4e5bf230fdbe17e592c2ec74fb34dba70eb5'>gnu: gd: Fix long patch filename.</a><span class='msg-avail'>...<span class='msg-tooltip'>This fixes the generation of a tarball with "make dist":

  tar: guix-1.3.0.10365-4c4f9/gnu/packages/patches/gd-Revert-fix-303-gdlib.pc-use-Requires-instead-of-Libs.patch:
  file name is too long (max 99); not dumped

* gnu/packages/patches/gd-Revert-fix-303-gdlib.pc-use-Requires-instead-of-Libs.patch:
  Rename patch to ...
* gnu/packages/patches/gd-Revert-fix-303-gdlib.pc.patch: ... this.
* gnu/packages/gd.scm (gd)[source]: Update patch filename.
* gnu/local.mk (dist_patch_DATA): Update patch filename.
</span></span></td><td>Vagrant Cascadian</td></tr>