Fix an "invalid read during ID3v2 tag parsing". https://security-tracker.debian.org/tracker/TEMP-0000000-57E7C1 https://gitlab.freedesktop.org/gstreamer/gst-plugins-base/-/issues/876 Patch copied from upstream source repository: https://gitlab.freedesktop.org/gstreamer/gst-plugins-base/-/commit/f4a1428a6997658625d529b9db60fde812fbf1ee From f4a1428a6997658625d529b9db60fde812fbf1ee Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Tim-Philipp=20M=C3=BCller?= Date: Wed, 3 Mar 2021 01:08:25 +0000 Subject: [PATCH] tag: id3v2: fix frame size check and potential invalid reads Check the right variable when checking if there's enough data left to read the frame size. Closes https://gitlab.freedesktop.org/gstreamer/gst-plugins-base/-/issues/876 Part-of: --- gst-libs/gst/tag/id3v2frames.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/gst-libs/gst/tag/id3v2frames.c b/gst-libs/gst/tag/id3v2frames.c index 8e9f78254..f39659bf7 100644 --- a/gst-libs/gst/tag/id3v2frames.c +++ b/gst-libs/gst/tag/id3v2frames.c @@ -109,7 +109,7 @@ id3v2_parse_frame (ID3TagsWorking * work) if (work->frame_flags & (ID3V2_FRAME_FORMAT_COMPRESSION | ID3V2_FRAME_FORMAT_DATA_LENGTH_INDICATOR)) { - if (work->hdr.frame_data_size <= 4) + if (frame_data_size <= 4) return FALSE; if (ID3V2_VER_MAJOR (work->hdr.version) == 3) { work->parse_size = GST_READ_UINT32_BE (frame_data); -- 2.31.1 ue='0c5141d1c2e09b017fbe68edacaf4f66465990e7'/>
path: root/.gitignore
AgeCommit message (Expand)Author
2023-04-24Add mumi config....* .mumi/config: New file. * .gitignore: Add .mumi/current-issue. Arun Isaac
2022-07-03etc: Add teams.scm....* etc/teams.scm.in: New file. * configure.ac: Generate executable. * .gitignore: Ignore generated file. Ricardo Wurmus
2022-06-05gitignore: Add .DS_Store....Ignore MacOS specific file: https://en.wikipedia.org/wiki/.DS_Store Signed-off-by: Mathieu Othacehe <othacehe@gnu.org> Pavel Shlyak
2021-10-16.gitignore: Ignore more autotools directories....* .gitignore: Add pattern to ignore ".am[0-9]*/". Signed-off-by: Maxim Cournoyer <maxim.cournoyer@gmail.com> Sarah Morgensen
2021-10-16.gitignore: Ignore more temporary test directories....* .gitignore: Add pattern to ignore "/t-*/". Signed-off-by: Maxim Cournoyer <maxim.cournoyer@gmail.com> Sarah Morgensen
2021-09-20etc: Add systemd files for running ‘guix gc’ periodically...* etc/guix-gc.service.in: New file. * etc/guix-gc.timer: Likewise. * .gitignore: Ignore generated ‘guix-gc.service’. * nix/local.mk (nodist_systemdservice_DATA): Add ‘guix-gc.service’ and ‘guix-gc.timer’. (EXTRA_DIST): Add ‘guix-gc.service.in’ and ‘guix-gc.timer’. * doc/guix.texi (Binary Installation): Mention the new systemd files. Signed-off-by: Mathieu Othacehe <othacehe@gnu.org> Thiago Jung Bauermann