From 88c9657960a6c5d3673a25c266781e876c181add Mon Sep 17 00:00:00 2001
From: Hector Marco-Gisbert <hecmargi@upv.es>
Date: Fri, 13 Nov 2015 16:21:09 +0100
Subject: [PATCH] Fix security issue when reading username and password

  This patch fixes two integer underflows at:
    * grub-core/lib/crypto.c
    * grub-core/normal/auth.c

Signed-off-by: Hector Marco-Gisbert <hecmargi@upv.es>
Signed-off-by: Ismael Ripoll-Ripoll <iripoll@disca.upv.es>
---
 grub-core/lib/crypto.c  | 2 +-
 grub-core/normal/auth.c | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/grub-core/lib/crypto.c b/grub-core/lib/crypto.c
index 010e550..524a3d8 100644
--- a/grub-core/lib/crypto.c
+++ b/grub-core/lib/crypto.c
@@ -468,7 +468,7 @@ grub_password_get (char buf[], unsigned buf_size)
 	  break;
 	}
 
-      if (key == '\b')
+      if (key == '\b' && cur_len)
 	{
 	  cur_len--;
 	  continue;
diff --git a/grub-core/normal/auth.c b/grub-core/normal/auth.c
index c6bd96e..5782ec5 100644
--- a/grub-core/normal/auth.c
+++ b/grub-core/normal/auth.c
@@ -172,7 +172,7 @@ grub_username_get (char buf[], unsigned buf_size)
 	  break;
 	}
 
-      if (key == '\b')
+      if (key == '\b' && cur_len)
 	{
 	  cur_len--;
 	  grub_printf ("\b");
-- 
1.9.1

T?id=805505b6000051e5a940d8f076a556f1ecff40bd'>tree</a><a href='/guix/commit/CODE-OF-CONDUCT?id=805505b6000051e5a940d8f076a556f1ecff40bd'>commit</a><a href='/guix/diff/CODE-OF-CONDUCT?id=805505b6000051e5a940d8f076a556f1ecff40bd'>diff</a></td><td class='form'><form class='right' method='get' action='/guix/log/CODE-OF-CONDUCT'>
<input type='hidden' name='id' value='805505b6000051e5a940d8f076a556f1ecff40bd'/><select name='qt'>
<option value='grep'>log msg</option>
<option value='author'>author</option>
<option value='committer'>committer</option>
<option value='range'>range</option>
</select>
<input class='txt' type='search' size='10' name='q' value=''/>
<input type='submit' value='search'/>
</form>
</td></tr></table>
<div class='path'>path: <a href='/guix/log/?id=805505b6000051e5a940d8f076a556f1ecff40bd'>root</a>/<a href='/guix/log/CODE-OF-CONDUCT?id=805505b6000051e5a940d8f076a556f1ecff40bd'>CODE-OF-CONDUCT</a></div><div class='content'><table class='list nowrap'><tr class='nohover'><th class='left'>Age</th><th class='left'>Commit message (<a href='/guix/log/CODE-OF-CONDUCT?id=805505b6000051e5a940d8f076a556f1ecff40bd&amp;showmsg=1'>Expand</a>)</th><th class='left'>Author</th></tr>
<tr><td><span title='2022-03-01 13:18:01 -0500'>2022-03-01</span></td><td><a href='/guix/commit/CODE-OF-CONDUCT?id=c67912011154e2b347cdf6f3e633e87fd44f409c'>CODE-OF-CONDUCT: Add a top notice.</a><span class='msg-avail'>...<span class='msg-tooltip'>* CODE-OF-CONDUCT: Add a top notice.
</span></span></td><td>Maxim Cournoyer</td></tr>
<tr><td><span title='2022-03-01 13:07:04 -0500'>2022-03-01</span></td><td><a href='/guix/commit/CODE-OF-CONDUCT?id=4254d74b4ca6d4aa78b7fa055fc9ec72a2e93ad3'>CODE-OF-CONDUCT: Update to version 2.1.</a><span class='msg-avail'>...<span class='msg-tooltip'>* CODE-OF-CONDUCT: Update to version 2.1.
</span></span></td><td>Maxim Cournoyer</td></tr>