From upstream PR: https://github.com/urfave/cli/pull/1299

From: William Wilson <william.wilson@canonical.com>
Date: Tue, 31 Aug 2021 14:19:17 -0500
Subject: Make test case compatible with Go 1.17

As of Go 1.17, the go flag package will panic if given a syntactically invalid
flag. This causes TestApp_RunAsSubCommandIncorrectUsage to panic and therefore
fail. See https://golang.org/doc/go1.17#flag for more information.

---
diff --git a/app_test.go b/app_test.go
index 7c38f6048..76e211d68 100644
--- a/app_test.go
+++ b/app_test.go
@@ -476,18 +476,18 @@ func TestApp_RunAsSubCommandIncorrectUsage(t *testing.T) {
 	a := App{
 		Name: "cmd",
 		Flags: []Flag{
-			&StringFlag{Name: "--foo"},
+			&StringFlag{Name: "foo"},
 		},
 		Writer: bytes.NewBufferString(""),
 	}
 
 	set := flag.NewFlagSet("", flag.ContinueOnError)
-	_ = set.Parse([]string{"", "---foo"})
+	_ = set.Parse([]string{"", "-bar"})
 	c := &Context{flagSet: set}
 
 	err := a.RunAsSubcommand(c)
 
-	expect(t, err, errors.New("bad flag syntax: ---foo"))
+	expect(t, err.Error(), "flag provided but not defined: -bar")
 }
 
 func TestApp_CommandWithFlagBeforeTerminator(t *testing.T) {
/installer.scm'>log</a><a href='/guix/tree/gnu/installer.scm?id=70386806e1f8428ad310373bd491aa9f833947c4'>tree</a><a href='/guix/commit/gnu/installer.scm?id=70386806e1f8428ad310373bd491aa9f833947c4'>commit</a><a href='/guix/diff/gnu/installer.scm?id=70386806e1f8428ad310373bd491aa9f833947c4'>diff</a></td><td class='form'><form class='right' method='get' action='/guix/log/gnu/installer.scm'>
<input type='hidden' name='id' value='70386806e1f8428ad310373bd491aa9f833947c4'/><select name='qt'>
<option value='grep'>log msg</option>
<option value='author'>author</option>
<option value='committer'>committer</option>
<option value='range'>range</option>
</select>
<input class='txt' type='search' size='10' name='q' value=''/>
<input type='submit' value='search'/>
</form>
</td></tr></table>
<div class='path'>path: <a href='/guix/log/?id=70386806e1f8428ad310373bd491aa9f833947c4'>root</a>/<a href='/guix/log/gnu?id=70386806e1f8428ad310373bd491aa9f833947c4'>gnu</a>/<a href='/guix/log/gnu/installer.scm?id=70386806e1f8428ad310373bd491aa9f833947c4'>installer.scm</a></div><div class='content'><table class='list nowrap'><tr class='nohover'><th class='left'>Age</th><th class='left'>Commit message (<a href='/guix/log/gnu/installer.scm?id=70386806e1f8428ad310373bd491aa9f833947c4&amp;showmsg=1'>Expand</a>)</th><th class='left'>Author</th></tr>
<tr><td><span title='2023-12-25 19:58:21 +0200'>2023-12-25</span></td><td><a href='/guix/commit/gnu/installer.scm?id=3e41b252cfc81508bfcd0ac7103df212b35c3b91'>gnu: Adjust to removing ed.scm and nano.scm</a><span class='msg-avail'>...<span class='msg-tooltip'>This is a follow-up to f6817e71dff7d0d9fdb55db8b85a1d3d04e2bf5a and
e11e65a9ad08e18ea2faac3c9f4639a7b189bf76.

* gnu/installer.scm, gnu/packages/algebra.scm, gnu/packages/base.scm,
gnu/packages/cook.scm, gnu/packages/lisp.scm,
gnu/packages/patchutils.scm, gnu/packages/version-control.scm,
gnu/packages/web-browsers.scm, gnu/system.scm: Adjust module imports.

Change-Id: I25e5519fa003c35a14b81c3dda37b24527858634
</span></span></td><td>Efraim Flashner</td></tr>
<tr><td><span title='2023-12-02 12:25:45 +0100'>2023-12-02</span></td><td><a href='/guix/commit/gnu/installer.scm?id=b0715d7cd2a74bc231751f8afc9dffb2047501ac'>gnu: Use ‘libc-utf8-locales-for-target’.</a><span class='msg-avail'>...<span class='msg-tooltip'>* guix/packages.scm (%standard-patch-inputs): Use
‘libc-utf8-locales-for-target’ instead of ‘glibc-utf8-locales’.
* guix/self.scm (%packages): Likewise.
* gnu/home/services/ssh.scm (file-join): Likewise
* gnu/installer.scm (build-compiled-file): Likewise.
* gnu/packages/chromium.scm (ungoogled-chromium/wayland): Likewise.
* gnu/packages/gnome.scm (libgweather4, tracker): Likewise.
* gnu/packages/javascript.scm (js-mathjax): Likewise.
* gnu/packages/package-management.scm (guix, flatpak): Likewise.
* gnu/packages/raspberry-pi.scm (raspi-arm64-chainloader): Likewise.
* gnu/packages/suckless.scm (svkbd): Likewise.
* gnu/services.scm (cleanup-gexp): Likewise.
* gnu/services/base.scm (guix-publish-shepherd-service): Likewise.
* gnu/services/guix.scm (guix-build-coordinator-shepherd-services)
(guix-build-coordinator-agent-shepherd-services): Likewise.
* gnu/services/guix.scm (guix-build-coordinator-queue-builds-shepherd-services):
(guix-data-service-shepherd-services)
(nar-herder-shepherd-services)
(bffe-shepherd-services): Likewise.
* gnu/services/web.scm (anonip-shepherd-service)
(mumi-shepherd-services): Likewise.
* gnu/system/image.scm (system-disk-image, system-iso9660-image)
(system-docker-image, system-tarball-image): Likewise.
* gnu/system/install.scm (%installation-services): Likewise.
* guix/profiles.scm (info-dir-file): Likewise.
(ca-certificate-bundle, profile-derivation): Likewise.
* guix/scripts/pack.scm (store-database, set-utf8-locale): Likewise.
* tests/pack.scm: Likewise.
* tests/profiles.scm ("profile-derivation, cross-compilation"):
Likewise.

Co-authored-by: Ludovic Courtès &lt;ludo@gnu.org&gt;
Co-authored-by: Christopher Baines &lt;mail@cbaines.net&gt;
Change-Id: I24239f427bcc930c29d2ba5d00dc615960a6c374
</span></span></td><td>Janneke Nieuwenhuizen</td></tr>