From upstream PR: https://github.com/urfave/cli/pull/1299

From: William Wilson <william.wilson@canonical.com>
Date: Tue, 31 Aug 2021 14:19:17 -0500
Subject: Make test case compatible with Go 1.17

As of Go 1.17, the go flag package will panic if given a syntactically invalid
flag. This causes TestApp_RunAsSubCommandIncorrectUsage to panic and therefore
fail. See https://golang.org/doc/go1.17#flag for more information.

---
diff --git a/app_test.go b/app_test.go
index 7c38f6048..76e211d68 100644
--- a/app_test.go
+++ b/app_test.go
@@ -476,18 +476,18 @@ func TestApp_RunAsSubCommandIncorrectUsage(t *testing.T) {
 	a := App{
 		Name: "cmd",
 		Flags: []Flag{
-			&StringFlag{Name: "--foo"},
+			&StringFlag{Name: "foo"},
 		},
 		Writer: bytes.NewBufferString(""),
 	}
 
 	set := flag.NewFlagSet("", flag.ContinueOnError)
-	_ = set.Parse([]string{"", "---foo"})
+	_ = set.Parse([]string{"", "-bar"})
 	c := &Context{flagSet: set}
 
 	err := a.RunAsSubcommand(c)
 
-	expect(t, err, errors.New("bad flag syntax: ---foo"))
+	expect(t, err.Error(), "flag provided but not defined: -bar")
 }
 
 func TestApp_CommandWithFlagBeforeTerminator(t *testing.T) {
guix/log/gnu/installer/utils.scm'>log</a><a href='/guix/tree/gnu/installer/utils.scm?id=176440c056fdde6da98b11720989b1ed060ec97c'>tree</a><a href='/guix/commit/gnu/installer/utils.scm?id=176440c056fdde6da98b11720989b1ed060ec97c'>commit</a><a href='/guix/diff/gnu/installer/utils.scm?id=176440c056fdde6da98b11720989b1ed060ec97c'>diff</a></td><td class='form'><form class='right' method='get' action='/guix/log/gnu/installer/utils.scm'>
<input type='hidden' name='id' value='176440c056fdde6da98b11720989b1ed060ec97c'/><select name='qt'>
<option value='grep'>log msg</option>
<option value='author'>author</option>
<option value='committer'>committer</option>
<option value='range'>range</option>
</select>
<input class='txt' type='search' size='10' name='q' value=''/>
<input type='submit' value='search'/>
</form>
</td></tr></table>
<div class='path'>path: <a href='/guix/log/?id=176440c056fdde6da98b11720989b1ed060ec97c'>root</a>/<a href='/guix/log/gnu?id=176440c056fdde6da98b11720989b1ed060ec97c'>gnu</a>/<a href='/guix/log/gnu/installer?id=176440c056fdde6da98b11720989b1ed060ec97c'>installer</a>/<a href='/guix/log/gnu/installer/utils.scm?id=176440c056fdde6da98b11720989b1ed060ec97c'>utils.scm</a></div><div class='content'><table class='list nowrap'><tr class='nohover'><th class='left'>Age</th><th class='left'>Commit message (<a href='/guix/log/gnu/installer/utils.scm?id=176440c056fdde6da98b11720989b1ed060ec97c&amp;showmsg=1'>Expand</a>)</th><th class='left'>Author</th></tr>
<tr><td><span title='2022-12-09 17:49:22 +0100'>2022-12-09</span></td><td><a href='/guix/commit/gnu/installer/utils.scm?id=591af24ade1021d91a3e7c62fcc7a8c90f00d4bb'>installer: Print progress bars and such as soon as \r is read.</a><span class='msg-avail'>...<span class='msg-tooltip'>Fixes &lt;https://issues.guix.gnu.org/59922&gt;.

Previously progress bars and related things would be buffered by
'run-external-command-with-line-hooks' until \n is read.

* gnu/installer/utils.scm (run-external-command-with-line-hooks): Use
'read-delimited' rather than 'get-line'.  Pass 'concat as the last
argument.
(%display-line-hook): Remove.
(run-command): Use 'display' instead of '%display-line-hook'.
(%syslog-line-hook): Add "\n" when LINE doesn't end in \n.
(%installer-log-line-hook): Do not add an extra newline.
(installer-log-line): Add an extra newline.
</span></span></td><td>Ludovic Courtès</td></tr>
<tr><td><span title='2022-10-20 10:50:50 +0200'>2022-10-20</span></td><td><a href='/guix/commit/gnu/installer/utils.scm?id=96bb00d20336f43fac2c42662e4b1d300e624738'>installer: Run the "guix system init" command in a PTY.</a><span class='msg-avail'>...<span class='msg-tooltip'>Fixes: &lt;https://issues.guix.gnu.org/55360&gt;

* gnu/installer/utils.scm (run-external-command-with-handler/tty): New
procedure.
(run-external-command-with-line-hooks, run-command): Add a TTY? argument.
* gnu/installer/final.scm (install-system): Call run-command with TTY?
argument set to #true.
</span></span></td><td>Mathieu Othacehe</td></tr>
<tr><td><span title='2022-09-22 16:00:29 +0200'>2022-09-22</span></td><td><a href='/guix/commit/gnu/installer/utils.scm?id=4814ec284f8a2870e6457c05f414ad31df4e3f57'>installer: Move &lt;secret&gt; to utils and use it for crypt passwords.</a><span class='msg-avail'>...<span class='msg-tooltip'>* gnu/installer/user.scm (&lt;secret&gt;, secret?, make-secret, secret-content): Move
to utils.scm.
* gnu/installer/utils.scm (&lt;secret&gt;, secret?, make-secret, secret-content):
Moved from user.scm.
* gnu/installer/newt/partition.scm (prompt-luks-passwords): Make password a
&lt;secret&gt;.
* gnu/installer/parted.scm (luks-format-and-open): Unwrap secret.

Signed-off-by: Mathieu Othacehe &lt;othacehe@gnu.org&gt;
</span></span></td><td>Josselin Poiret</td></tr>