We want to allow builds in chroots that lack /bin/sh.  Thus, system(3)
and popen(3) need to be tweaked to use the right shell.  For the bootstrap
glibc, we just use whatever `sh' can be found in $PATH.  The final glibc
instead uses the hard-coded absolute file name of `bash'.

In addition, status should be initialized to 0 and not -1.

diff --git a/libio/iopopen.c b/libio/iopopen.c
index 4cc405f2de..8842c989c8 100644
--- a/libio/iopopen.c
+++ b/libio/iopopen.c
@@ -86,7 +86,7 @@ spawn_process (posix_spawn_file_actions_t *fa, FILE *fp, const char *command,
 	}
     }
 
-  err = __posix_spawn (&((_IO_proc_file *) fp)->pid, _PATH_BSHELL, fa, 0,
+  err = __posix_spawnp (&((_IO_proc_file *) fp)->pid, "sh", fa, 0,
 		       (char *const[]){ (char*) "sh", (char*) "-c", (char*) "--",
 		       (char *) command, NULL }, __environ);
   if (err != 0)
diff --git a/sysdeps/posix/system.c b/sysdeps/posix/system.c
index 488b95163b..56b8a028ae 100644
--- a/sysdeps/posix/system.c
+++ b/sysdeps/posix/system.c
@@ -100,7 +100,7 @@ cancel_handler (void *arg)
 static int
 do_system (const char *line)
 {
-  int status = -1;
+  int status = 0;
   int ret;
   pid_t pid;
   struct sigaction sa;
@@ -144,7 +144,7 @@ do_system (const char *line)
   __posix_spawnattr_setflags (&spawn_attr,
 			      POSIX_SPAWN_SETSIGDEF | POSIX_SPAWN_SETSIGMASK);
 
-  ret = __posix_spawn (&pid, SHELL_PATH, 0, &spawn_attr,
+  ret = __posix_spawnp (&pid, SHELL_NAME, 0, &spawn_attr,
 		       (char *const[]){ (char *) SHELL_NAME,
 					(char *) "-c",
 					(char *) "--",
diff --git a/include/spawn.h b/include/spawn.h
index 4a0b1849da..9e47f74391 100644
--- a/include/spawn.h
+++ b/include/spawn.h
@@ -5,6 +5,9 @@
 __typeof (posix_spawn) __posix_spawn;
 libc_hidden_proto (__posix_spawn)

+__typeof (posix_spawnp) __posix_spawnp;
+libc_hidden_proto (__posix_spawnp)
+
 __typeof (posix_spawn_file_actions_addclose)
   __posix_spawn_file_actions_addclose attribute_hidden;

--- a/posix/spawnp.c
+++ b/posix/spawnp.c
@@ -31,6 +31,7 @@ __posix_spawnp (pid_t *pid, const char *file,
                   SPAWN_XFLAGS_USE_PATH);
 }
 versioned_symbol (libc, __posix_spawnp, posix_spawnp, GLIBC_2_15);
+libc_hidden_def (__posix_spawnp)


 #if SHLIB_COMPAT (libc, GLIBC_2_2, GLIBC_2_15)

02cbce8f94bcfe'>tests</a>/<a href='/guix/log/tests/guix-shell-export-manifest.sh?id=97256395df705dd9f9c76d18a302cbce8f94bcfe'>guix-shell-export-manifest.sh</a></div><div class='content'><table class='list nowrap'><tr class='nohover'><th class='left'>Age</th><th class='left'>Commit message (<a href='/guix/log/tests/guix-shell-export-manifest.sh?id=97256395df705dd9f9c76d18a302cbce8f94bcfe&amp;showmsg=1'>Expand</a>)</th><th class='left'>Author</th></tr>
<tr><td><span title='2022-06-16 23:57:40 +0200'>2022-06-16</span></td><td><a href='/guix/commit/tests/guix-shell-export-manifest.sh?id=925a57c5d04553ff6c514867348e7d3c5c22ca66'>shell: Fix '--export-manifest' for cached profiles and when '-p' is used.</a><span class='msg-avail'>...<span class='msg-tooltip'>Fixes &lt;https://issues.guix.gnu.org/55521&gt;.

* guix/scripts/shell.scm (export-manifest): When computing 'manifest',
honor the 'profile key.
* tests/guix-shell-export-manifest.sh: Add test.
</span></span></td><td>Ludovic Courtès</td></tr>
<tr><td><span title='2022-06-01 22:22:19 +0200'>2022-06-01</span></td><td><a href='/guix/commit/tests/guix-shell-export-manifest.sh?id=2acc83daa5a3dd1b4ed3f8c32ecadf1313e6fd18'>shell: '--export-manifest -D x -D y' generates a valid manifest.</a><span class='msg-avail'>...<span class='msg-tooltip'>* guix/scripts/shell.scm (manifest-&gt;code*): Add missing 'list' in
generated 'concatenate-manifests' call.
* tests/guix-shell-export-manifest.sh: Add test.
</span></span></td><td>Ludovic Courtès</td></tr>
<tr><td><span title='2022-04-08 18:14:35 +0200'>2022-04-08</span></td><td><a href='/guix/commit/tests/guix-shell-export-manifest.sh?id=20691c70cf2c5a61af7f906b65d57a524ecfc4f3'>tests: 'guix shell --export-manifest' test no longer needs networking.</a><span class='msg-avail'>...<span class='msg-tooltip'>* tests/guix-shell-export-manifest.sh: Use '--with-input' rather than
'--with-latest' as the latter would crash in the absence of network
access.
</span></span></td><td>Ludovic Courtès</td></tr>
<tr><td><span title='2022-04-04 22:58:04 +0200'>2022-04-04</span></td><td><a href='/guix/commit/tests/guix-shell-export-manifest.sh?id=c42b7baf13c7633b4512e94da7445299c57b247d'>shell: Add '--export-manifest'.</a><span class='msg-avail'>...<span class='msg-tooltip'>* guix/scripts/shell.scm (show-help, %options): Add '--export-manifest'.
(manifest-entry-version-prefix, manifest-&gt;code*)
(export-manifest): New procedures.
(guix-shell): Honor '--export-manifest'.
* tests/guix-shell-export-manifest.sh: New file.
* Makefile.am (SH_TESTS): Add it.
* doc/guix.texi (Invoking guix shell): Document '--export-manifest'.
(Invoking guix environment): Link to it.
(Invoking guix pack): Likewise.
</span></span></td><td>Ludovic Courtès</td></tr>