We want to allow builds in chroots that lack /bin/sh.  Thus, system(3)
and popen(3) need to be tweaked to use the right shell.  For the bootstrap
glibc, we just use whatever `sh' can be found in $PATH.  The final glibc
instead uses the hard-coded absolute file name of `bash'.

In addition, status should be initialized to 0 and not -1.

diff --git a/libio/iopopen.c b/libio/iopopen.c
index ebc381ed7c..e0d3ed1bc3 100644
--- a/libio/iopopen.c
+++ b/libio/iopopen.c
@@ -85,7 +85,7 @@ spawn_process (posix_spawn_file_actions_t *fa, FILE *fp, const char *command,
 	return false;
     }
 
-  if (__posix_spawn (&((_IO_proc_file *) fp)->pid, _PATH_BSHELL, fa, 0,
+  if (__posix_spawnp (&((_IO_proc_file *) fp)->pid, "sh", fa, 0,
 		     (char *const[]){ (char*) "sh", (char*) "-c",
 		     (char *) command, NULL }, __environ) != 0)
     return false;
diff --git a/sysdeps/posix/system.c b/sysdeps/posix/system.c
index a03f478fc7..94da6facf3 100644
--- a/sysdeps/posix/system.c
+++ b/sysdeps/posix/system.c
@@ -101,7 +101,7 @@ cancel_handler (void *arg)
 static int
 do_system (const char *line)
 {
-  int status = -1;
+  int status = 0;
   int ret;
   pid_t pid;
   struct sigaction sa;
@@ -145,7 +145,7 @@ do_system (const char *line)
   __posix_spawnattr_setflags (&spawn_attr,
 			      POSIX_SPAWN_SETSIGDEF | POSIX_SPAWN_SETSIGMASK);
 
-  ret = __posix_spawn (&pid, SHELL_PATH, 0, &spawn_attr,
+  ret = __posix_spawnp (&pid, SHELL_NAME, 0, &spawn_attr,
 		       (char *const[]){ (char *) SHELL_NAME,
 					(char *) "-c",
 					(char *) line, NULL },

--- a/include/spawn.h
+++ b/include/spawn.h
@@ -5,6 +5,9 @@
 __typeof (posix_spawn) __posix_spawn;
 libc_hidden_proto (__posix_spawn)

+__typeof (posix_spawnp) __posix_spawnp;
+libc_hidden_proto (__posix_spawnp)
+
 __typeof (posix_spawn_file_actions_addclose)
   __posix_spawn_file_actions_addclose attribute_hidden;

--- a/posix/spawnp.c
+++ b/posix/spawnp.c
@@ -31,6 +31,7 @@ __posix_spawnp (pid_t *pid, const char *file,
                   SPAWN_XFLAGS_USE_PATH);
 }
 versioned_symbol (libc, __posix_spawnp, posix_spawnp, GLIBC_2_15);
+libc_hidden_def (__posix_spawnp)


 #if SHLIB_COMPAT (libc, GLIBC_2_2, GLIBC_2_15)

nu/installer?id=1f8e29256ed5137477658c10ff9dca324202e96c'>installer</a>/<a href='/guix/log/gnu/installer/newt?id=1f8e29256ed5137477658c10ff9dca324202e96c'>newt</a></div><div class='content'><table class='list nowrap'><tr class='nohover'><th class='left'>Age</th><th class='left'>Commit message (<a href='/guix/log/gnu/installer/newt?id=1f8e29256ed5137477658c10ff9dca324202e96c&amp;showmsg=1'>Expand</a>)</th><th class='left'>Author</th></tr>
<tr><td><span title='2024-04-03 17:18:38 +0100'>2024-04-03</span></td><td><a href='/guix/commit/gnu/installer/newt?id=ac19e038b457d0585812091200005befd9b29259'>Switch order of the default substitute servers.</a><span class='msg-avail'>...</span></td><td>Christopher Baines</td></tr>
<tr><td><span title='2022-11-15 12:16:43 +0100'>2022-11-15</span></td><td><a href='/guix/commit/gnu/installer/newt?id=514fedbf3966b7fbab31a6c63b4210ec8b5b0c9a'>installer: Report known-unsupported PCI devices.</a><span class='msg-avail'>...</span></td><td>Ludovic Courtès</td></tr>
<tr><td><span title='2022-11-15 12:16:43 +0100'>2022-11-15</span></td><td><a href='/guix/commit/gnu/installer/newt?id=6b39c3afccbc2fa91746f379f46f6acfa47c8f62'>installer: Error page width is parameterized.</a><span class='msg-avail'>...</span></td><td>Ludovic Courtès</td></tr>
<tr><td><span title='2022-11-15 12:16:42 +0100'>2022-11-15</span></td><td><a href='/guix/commit/gnu/installer/newt?id=4f7ffb97a4c2f2ee7aa1c54c23a97e7c0447c08c'>installer: Warn about hardware support after the welcome page.</a><span class='msg-avail'>...</span></td><td>Ludovic Courtès</td></tr>
<tr><td><span title='2022-11-02 15:52:19 +0100'>2022-11-02</span></td><td><a href='/guix/commit/gnu/installer/newt?id=62a3756bd90c922c701e899a6c01c556d8e3c75a'>installer: Skip the backtrace page on user abort.</a><span class='msg-avail'>...</span></td><td>Mathieu Othacehe</td></tr>
<tr><td><span title='2022-11-02 15:52:19 +0100'>2022-11-02</span></td><td><a href='/guix/commit/gnu/installer/newt?id=80387bc7c3966602800116f5be3893c3d3044a96'>installer: Add core dump support.</a><span class='msg-avail'>...</span></td><td>Mathieu Othacehe</td></tr>
<tr><td><span title='2022-10-25 10:55:33 +0200'>2022-10-25</span></td><td><a href='/guix/commit/gnu/installer/newt?id=682639c107908426fe6bf0a1b8404b98b7820290'>installer: welcome: Warn when uvesafb gets used.</a><span class='msg-avail'>...</span></td><td>pelzflorian (Florian Pelz)</td></tr>