We want to allow builds in chroots that lack /bin/sh.  Thus, system(3)
and popen(3) need to be tweaked to use the right shell.  For the bootstrap
glibc, we just use whatever `sh' can be found in $PATH.  The final glibc
instead uses the hard-coded absolute file name of `bash'.

--- a/sysdeps/posix/system.c
+++ b/sysdeps/posix/system.c
@@ -106,8 +106,8 @@ do_system (const char *line)
       (void) UNBLOCK;
 
       /* Exec the shell.  */
-      (void) __execve (SHELL_PATH, (char *const *) new_argv, __environ);
+      (void) execvp (SHELL_NAME, (char *const *) new_argv);
       _exit (127);
     }
   else if (pid < (pid_t) 0)
     /* The fork failed.  */
--- a/libio/iopopen.c
+++ b/libio/iopopen.c
@@ -170,7 +170,7 @@ _IO_new_proc_open (fp, command, mode)
       for (p = proc_file_chain; p; p = p->next)
 	_IO_close (_IO_fileno ((_IO_FILE *) p));
 
-      _IO_execl ("/bin/sh", "sh", "-c", command, (char *) 0);
+      execlp ("sh", "sh", "-c", command, (char *) 0);
       _IO__exit (127);
     }
   _IO_close (child_end);


lass='tabs'><tr><td>
<a href='/guix/about/'>about</a><a href='/guix/'>summary</a><a href='/guix/refs/?id=46e236ff773fd8c5fe08230835e83bb84d1b0708'>refs</a><a class='active' href='/guix/log/tests/elpa.scm?showmsg=1'>log</a><a href='/guix/tree/tests/elpa.scm?id=46e236ff773fd8c5fe08230835e83bb84d1b0708'>tree</a><a href='/guix/commit/tests/elpa.scm?id=46e236ff773fd8c5fe08230835e83bb84d1b0708'>commit</a><a href='/guix/diff/tests/elpa.scm?id=46e236ff773fd8c5fe08230835e83bb84d1b0708'>diff</a></td><td class='form'><form class='right' method='get' action='/guix/log/tests/elpa.scm'>
<input type='hidden' name='id' value='46e236ff773fd8c5fe08230835e83bb84d1b0708'/><input type='hidden' name='showmsg' value='1'/><select name='qt'>
<option value='grep'>log msg</option>
<option value='author'>author</option>
<option value='committer'>committer</option>
<option value='range'>range</option>
</select>
<input class='txt' type='search' size='10' name='q' value=''/>
<input type='submit' value='search'/>
</form>
</td></tr></table>
<div class='path'>path: <a href='/guix/log/?id=46e236ff773fd8c5fe08230835e83bb84d1b0708&amp;showmsg=1'>root</a>/<a href='/guix/log/tests?id=46e236ff773fd8c5fe08230835e83bb84d1b0708&amp;showmsg=1'>tests</a>/<a href='/guix/log/tests/elpa.scm?id=46e236ff773fd8c5fe08230835e83bb84d1b0708&amp;showmsg=1'>elpa.scm</a></div><div class='content'><table class='list nowrap'><tr class='nohover'><th class='left'>Age</th><th class='left'>Commit message (<a href='/guix/log/tests/elpa.scm?id=46e236ff773fd8c5fe08230835e83bb84d1b0708'>Collapse</a>)</th><th class='left'>Author</th></tr>
<tr class='logheader'><td><span title='2021-03-06 11:41:48 +0100'>2021-03-06</span></td><td class='logsubject'><a href='/guix/commit/tests/elpa.scm?id=c05ceaf2b650d090cf39a048193505cb4e6bd257'>tests: do not hard code HTTP ports</a></td><td>Maxime Devos</td></tr>
<tr class='nohover-highlight'><td/><td colspan='3' class='logmsg'>
Previously, test cases could fail if some process was listening
at a hard-coded port.  This patch eliminates most of these potential
failures, by automatically assigning an unbound port.  This should
allow for building multiple guix trees in parallel outside a build
container, though this is currently untested.

The test "home-page: Connection refused" in tests/lint.scm still
hardcodes port 9999, however.

* guix/tests/http.scm
  (http-server-can-listen?): remove now unused procedure.
  (%http-server-port): default to port 0, meaning the OS
  will automatically choose a port.
  (open-http-server-socket): remove the false statement claiming
  this procedure is exported and also return the allocated port
  number.
  (%local-url): raise an error if the port is obviously unbound.
  (call-with-http-server): set %http-server-port to the allocated
  port while the thunk is called.
* tests/derivations.scm: adjust test cases to use automatically
  assign a port.  As there is no risk of a port conflict now,
  do not make any tests conditional upon 'http-server-can-listen?'
  anymore.
* tests/elpa.scm: likewise.
* tests/lint.scm: likewise, and add a TODO comment about a port
  that is still hard-coded.
* tests/texlive.scm: likewise.

Signed-off-by: Ludovic Courtès &lt;ludo@gnu.org&gt;


</td></tr>
<tr class='logheader'><td><span title='2020-12-02 22:09:23 +0100'>2020-12-02</span></td><td class='logsubject'><a href='/guix/commit/tests/elpa.scm?id=bea3b17739fc591b8cf6db1f8d28a6f6c9585577'>import: utils: 'recursive-import' accepts an optional version parameter.</a></td><td>Martin Becze</td></tr>
<tr class='nohover-highlight'><td/><td colspan='3' class='logmsg'>
This adds a key VERSION to 'recursive-import' and moves the parameter REPO to
a key. This also changes all the places that rely on 'recursive-import'.

* guix/import/utils.scm (recursive-import): Add the VERSION key. Make REPO a
  key.
  (package-&gt;definition): Add optional 'append-version?'.
* guix/scripts/import/crate.scm (guix-import-crate): Add the VERSION key.
* guix/import/crate.scm (crate-&gt;guix-package): Add the VERSION key.
  (crate-recursive-import): Pass VERSION to recursive-import, remove now
  unnecessary code.
* guix/import/cran.scm (cran-&gt;guix-package, cran-recursive-import): Change the
  REPO parameter to a key.
* guix/import/elpa.scm (elpa-&gt;guix-package, elpa-recursive-import): Likewise.
* guix/import/gem.scm (gem-&gt;guix-package, recursive-import): Likewise.
* guix/import/opam.scm (opam-recurive-import): Likewise.
* guix/import/pypi.scm (pypi-recursive-import): Likewise.
* guix/import/stackage.scm (stackage-recursive-import): Likewise.
* guix/scripts/import/cran.scm (guix-import-cran): Likewise.
* guix/scripts/import/elpa.scm (guix-import-elpa): Likewise.
* tests/elpa.scm (eval-test-with-elpa): Likewise.
* tests/import-utils.scm (recursive-import): Likewise.

Co-authored-by: Hartmut Goebel &lt;h.goebel@crazy-compilers.com&gt;


</td></tr>
<tr class='logheader'><td><span title='2020-01-16 23:14:05 +0100'>2020-01-16</span></td><td class='logsubject'><a href='/guix/commit/tests/elpa.scm?id=9d6c6cb20ef240221fc9a8e155f4bfa53e71bce4'>import: elpa: Rewrite test to use an HTTP server instead of mocking.</a></td><td>Ludovic Courtès</td></tr>
<tr class='nohover-highlight'><td/><td colspan='3' class='logmsg'>
* guix/import/elpa.scm (elpa-url): Add 'gnu/http'.
(elpa-&gt;guix-package): Handle it.
* tests/elpa.scm (elpa-package-info-mock, auctex-readme-mock)
(elpa-version-&gt;string, package-source-url, ensure-list)
(package-home-page, make-elpa-package): Remove.
&lt;top level&gt;: Call '%http-server-port'.
(eval-test-with-elpa): Remove uses of 'mock'.  Use 'with-http-server'
and parameterize 'current-http-proxy' instead.


</td></tr>