We want to allow builds in chroots that lack /bin/sh.  Thus, system(3)
and popen(3) need to be tweaked to use the right shell.  For the bootstrap
glibc, we just use whatever `sh' can be found in $PATH.  The final glibc
instead uses the hard-coded absolute file name of `bash'.

--- a/sysdeps/posix/system.c
+++ b/sysdeps/posix/system.c
@@ -106,8 +106,8 @@ do_system (const char *line)
       (void) UNBLOCK;
 
       /* Exec the shell.  */
-      (void) __execve (SHELL_PATH, (char *const *) new_argv, __environ);
+      (void) execvp (SHELL_NAME, (char *const *) new_argv);
       _exit (127);
     }
   else if (pid < (pid_t) 0)
     /* The fork failed.  */
--- a/libio/iopopen.c
+++ b/libio/iopopen.c
@@ -170,7 +170,7 @@ _IO_new_proc_open (fp, command, mode)
       for (p = proc_file_chain; p; p = p->next)
 	_IO_close (_IO_fileno ((_IO_FILE *) p));
 
-      _IO_execl ("/bin/sh", "sh", "-c", command, (char *) 0);
+      execlp ("sh", "sh", "-c", command, (char *) 0);
       _IO__exit (127);
     }
   _IO_close (child_end);


bout/'>about</a><a href='/guix/'>summary</a><a href='/guix/refs/?id=bd73bec121ab894f8b87856e6883fd8791d47f9f'>refs</a><a class='active' href='/guix/log/gnu/build/activation.scm'>log</a><a href='/guix/tree/gnu/build/activation.scm?id=bd73bec121ab894f8b87856e6883fd8791d47f9f'>tree</a><a href='/guix/commit/gnu/build/activation.scm?id=bd73bec121ab894f8b87856e6883fd8791d47f9f'>commit</a><a href='/guix/diff/gnu/build/activation.scm?id=bd73bec121ab894f8b87856e6883fd8791d47f9f'>diff</a></td><td class='form'><form class='right' method='get' action='/guix/log/gnu/build/activation.scm'>
<input type='hidden' name='id' value='bd73bec121ab894f8b87856e6883fd8791d47f9f'/><select name='qt'>
<option value='grep'>log msg</option>
<option value='author'>author</option>
<option value='committer'>committer</option>
<option value='range'>range</option>
</select>
<input class='txt' type='search' size='10' name='q' value=''/>
<input type='submit' value='search'/>
</form>
</td></tr></table>
<div class='path'>path: <a href='/guix/log/?id=bd73bec121ab894f8b87856e6883fd8791d47f9f'>root</a>/<a href='/guix/log/gnu?id=bd73bec121ab894f8b87856e6883fd8791d47f9f'>gnu</a>/<a href='/guix/log/gnu/build?id=bd73bec121ab894f8b87856e6883fd8791d47f9f'>build</a>/<a href='/guix/log/gnu/build/activation.scm?id=bd73bec121ab894f8b87856e6883fd8791d47f9f'>activation.scm</a></div><div class='content'><table class='list nowrap'><tr class='nohover'><th class='left'>Age</th><th class='left'>Commit message (<a href='/guix/log/gnu/build/activation.scm?id=bd73bec121ab894f8b87856e6883fd8791d47f9f&amp;showmsg=1'>Expand</a>)</th><th class='left'>Author</th></tr>
<tr><td><span title='2023-08-20 02:00:00 +0200'>2023-08-20</span></td><td><a href='/guix/commit/gnu/build/activation.scm?id=5a2c3352d8f8a08a5ba01542a3f282799e503d33'>Revert "gnu: system: Add home-directory-permissions field to &lt;user-account&gt;."</a><span class='msg-avail'>...<span class='msg-tooltip'>This reverts commit e9a5eebc785cb843034b38c5c5a6dd10904bdf2a, which
as far as I can tell breaks system roll-backs thusly:

[...]
In gnu/build/accounts.scm:
   239:27  3 (_ #&lt;&lt;password-entry&gt; name: "root" password: "x" uid: 0 gid: 0 real-name: "System &gt;)
In unknown file:
           2 (string-join ("root" "x" "0" "0" "System administrator" "/root" #t) ":" #&lt;undefined&gt;)
In ice-9/boot-9.scm:
  1685:16  1 (raise-exception _ #:continuable? _)
  1685:16  0 (raise-exception _ #:continuable? _)

ice-9/boot-9.scm:1685:16: In procedure raise-exception:
In procedure string-append: Wrong type (expecting string): #t
</span></span></td><td>Tobias Geerinckx-Rice</td></tr>
<tr><td><span title='2023-08-25 15:12:54 +0200'>2023-08-25</span></td><td><a href='/guix/commit/gnu/build/activation.scm?id=e9a5eebc785cb843034b38c5c5a6dd10904bdf2a'>gnu: system: Add home-directory-permissions field to &lt;user-account&gt;.</a><span class='msg-avail'>...<span class='msg-tooltip'>* gnu/system/accounts.scm (&lt;user-account&gt;)[home-directory-permissions]: New
field.
(user-account-home-directory-permissions): New accessor.
* gnu/build/activation.scm (activate-users+groups): Use home directory
permission bits from the user account object.
* doc/guix.texi (User Accounts): Document new field.

Signed-off-by: Josselin Poiret &lt;dev@jpoiret.xyz&gt;
</span></span></td><td>David Thompson</td></tr>
<tr><td><span title='2022-12-17 17:08:50 +0100'>2022-12-17</span></td><td><a href='/guix/commit/gnu/build/activation.scm?id=4d94cdf69889043dd8d9b1305f5f3946ec0f8ff6'>activation: Firmware activation handles missing support in kernel.</a><span class='msg-avail'>...<span class='msg-tooltip'>* gnu/build/activation.scm (activate-firmware): Check if firmware loading is
enabled before attempting to use it.
</span></span></td><td>Marius Bakke</td></tr>