We want to allow builds in chroots that lack /bin/sh.  Thus, system(3)
and popen(3) need to be tweaked to use the right shell.  For the bootstrap
glibc, we just use whatever `sh' can be found in $PATH.  The final glibc
instead uses the hard-coded absolute file name of `bash'.

--- a/sysdeps/posix/system.c
+++ b/sysdeps/posix/system.c
@@ -134,7 +134,7 @@ do_system (const char *line)
       INIT_LOCK ();
 
       /* Exec the shell.  */
-      (void) __execve (SHELL_PATH, (char *const *) new_argv, __environ);
+      (void) __execvpe (SHELL_NAME, (char *const *) new_argv, __environ);
       _exit (127);
     }
   else if (pid < (pid_t) 0)

--- a/libio/iopopen.c
+++ b/libio/iopopen.c
@@ -145,7 +145,7 @@ _IO_new_proc_open (fp, command, mode)
 	    _IO_close (fd);
 	}
 
-      _IO_execl ("/bin/sh", "sh", "-c", command, (char *) 0);
+      execlp ("sh", "sh", "-c", command, (char *) 0);
       _IO__exit (127);
     }
   _IO_close (child_end);


d></tr></table>
<table class='tabs'><tr><td>
<a href='/guix/about/'>about</a><a href='/guix/'>summary</a><a href='/guix/refs/?id=526171269d70f5c28820e2ac54c082def7068edd'>refs</a><a class='active' href='/guix/log/tests/uuid.scm'>log</a><a href='/guix/tree/tests/uuid.scm?id=526171269d70f5c28820e2ac54c082def7068edd'>tree</a><a href='/guix/commit/tests/uuid.scm?id=526171269d70f5c28820e2ac54c082def7068edd'>commit</a><a href='/guix/diff/tests/uuid.scm?id=526171269d70f5c28820e2ac54c082def7068edd'>diff</a></td><td class='form'><form class='right' method='get' action='/guix/log/tests/uuid.scm'>
<input type='hidden' name='id' value='526171269d70f5c28820e2ac54c082def7068edd'/><select name='qt'>
<option value='grep'>log msg</option>
<option value='author'>author</option>
<option value='committer'>committer</option>
<option value='range'>range</option>
</select>
<input class='txt' type='search' size='10' name='q' value=''/>
<input type='submit' value='search'/>
</form>
</td></tr></table>
<div class='path'>path: <a href='/guix/log/?id=526171269d70f5c28820e2ac54c082def7068edd'>root</a>/<a href='/guix/log/tests?id=526171269d70f5c28820e2ac54c082def7068edd'>tests</a>/<a href='/guix/log/tests/uuid.scm?id=526171269d70f5c28820e2ac54c082def7068edd'>uuid.scm</a></div><div class='content'><table class='list nowrap'><tr class='nohover'><th class='left'>Age</th><th class='left'>Commit message (<a href='/guix/log/tests/uuid.scm?id=526171269d70f5c28820e2ac54c082def7068edd&amp;showmsg=1'>Expand</a>)</th><th class='left'>Author</th></tr>
<tr><td><span title='2019-05-07 12:18:44 +0200'>2019-05-07</span></td><td><a href='/guix/commit/tests/uuid.scm?id=6c5790a2faf8ffc401e43b13425a707394e40874'>uuid: 'fat-uuid-&gt;string' preserves leading zeros.</a><span class='msg-avail'>...<span class='msg-tooltip'>Fixes &lt;https://bugs.gnu.org/35582&gt;.
Reported by sirgazil &lt;sirgazil@zoho.com&gt;.

Previously, leading zeros would be removed, leading to an "invalid"
UUID:

  (uuid-&gt;string (uuid "00CA-050E" 'fat32))
  ⇒ "CA-50E"
  (string-&gt;uuid "CA-50E" 'fat32)
  ⇒ #f

* gnu/system/uuid.scm (fat-uuid-&gt;string): Pad digits with zeros.
* tests/uuid.scm ("uuid, FAT32, leading zeros preserved"): New test.
</span></span></td><td>Ludovic Courtès</td></tr>
l.scm (%encrypted-root-not-boot-os,
%encrypted-root-not-boot-os): New os declaration.
(%encrypted-root-not-boot-installation-script): New script, whose contents
were initially taken from %encrypted-root-installation-script.
(%test-encrypted-root-not-boot-os): New test.
* gnu/system.scm (define-module): Export
operating-system-bootoader-crypto-devices and
boot-parameters-store-crypto-devices.
(&lt;boot-parameters&gt;): Add field store-crypto-devices.
(read-boot-parameters): Parse store-crypto-devices field.
[uuid-sexp-&gt;uuid]: New helper function extracted from
device-sexp-&gt;device.
(operating-system-bootloader-crypto-devices): New function.
(operating-system-bootcfg): Use
operating-system-bootloader-crypto-devices to provide its contents to
the bootloader configuration generation process.
(operating-system-boot-parameters): Add store-crypto-devices to the
generated boot-parameters.
(operating-system-boot-parameters-file): Likewise to the file with
the serialized structure.
* guix/scripts/system.scm (reinstall-bootloader): Use
boot-parameters-store-crypto-devices to provide its contents to the
bootloader configuration generation process.
* tests/boot-parameters.scm (%default-store-crypto-devices): New
variable.
(%grub-boot-parameters, test-read-boot-parameters): Use
%default-store-crypto-devices.
(tests store-crypto-devices): New tests.
</span></span></td><td>Miguel Ángel Arruga Vivas</td></tr>
<tr><td><span title='2020-11-01 02:28:38 +0100'>2020-11-01</span></td><td><a href='/guix/commit/tests/boot-parameters.scm?id=582cf9257cd1f9c969fbba5eb1c336ac8b975cde'>system: Add store-directory-prefix to boot-parameters.</a><span class='msg-avail'>...<span class='msg-tooltip'>Fixes &lt;http://issues.guix.gnu.org/44196&gt;

* gnu/machine/ssh.scm (roll-back-managed-host): Use
boot-parameters-store-directory-prefix.
* gnu/system.scm (define-module): Export
boot-parameters-store-directory-prefix.
(&lt;boot-parameters&gt;)[store-directory-prefix]: New field. It is used to
generate the correct paths when /gnu/store is installed on a btrfs
subvolume whose name doesn't match the final runtime path, as the
bootloader doesn't have knowledge about the final mounting points.
[boot-parameters-store-directory-prefix]: New accessor.
(read-boot-parameters): Read directory-prefix from store field.
(operating-system-boot-parameters-file): Add directory-prefix to
store field.
* guix/scripts/system.scm (reinstall-bootloader): Use
boot-parameters-store-directory-prefix.
* test/boot-parameters.scm (%default-btrfs-subvolume,
%default-store-directory-prefix): New variables.
(%grub-boot-parameters): Use %default-store-directory-prefix.
(%default-operating-system): Use %default-btrfs-subvolume.
(test-boot-parameters): Add directory-prefix.
(test optional fields): Add test for directory-prefix.
(test os store-directory-prefix): New test.
</span></span></td><td>Miguel Ángel Arruga Vivas</td></tr>
<tr><td><span title='2020-10-18 15:32:54 +0200'>2020-10-18</span></td><td><a href='/guix/commit/tests/boot-parameters.scm?id=9d449b945bbad5b7c66ed874b347f7f0ffd012e1'>system: Add locale to boot-parameters.</a><span class='msg-avail'>...<span class='msg-tooltip'>* gnu/system.scm (define-module)[export]: Add boot-parameters-locale.
(&lt;boot-parameters&gt;)[locale]: New field.
[boot-parameters-locale]: New accessor.
(read-boot-parameters): Read locale field.
(operating-system-boot-parameters): Provide operating-system locale to
boot-parameters record.
(opeating-system-boot-parameters-file): Likewise.
* Makefile.am (SCM_TESTS): Add tests/boot-parameters.scm.
* tests/boot-parameters.scm: New test file.
</span></span></td><td>Miguel Ángel Arruga Vivas</td></tr>