From f6110a8fee2ca36f8e2d2abecf3cba9fa7b8ea7d Mon Sep 17 00:00:00 2001
From: Florian Weimer <fweimer@redhat.com>
Date: Mon, 19 Jun 2017 17:09:55 +0200
Subject: [PATCH] CVE-2017-1000366: Ignore LD_LIBRARY_PATH for AT_SECURE=1
 programs [BZ #21624]

LD_LIBRARY_PATH can only be used to reorder system search paths, which
is not useful functionality.

This makes an exploitable unbounded alloca in _dl_init_paths unreachable
for AT_SECURE=1 programs.

patch from:
https://sourceware.org/git/?p=glibc.git;a=commit;h=f6110a8fee2ca36f8e2d2abecf3cba9fa7b8ea7d
---
 ChangeLog  | 7 +++++++
 elf/rtld.c | 3 ++-
 2 files changed, 9 insertions(+), 1 deletion(-)

diff --git a/elf/rtld.c b/elf/rtld.c
index 2446a87..2269dbe 100644
--- a/elf/rtld.c
+++ b/elf/rtld.c
@@ -2422,7 +2422,8 @@ process_envvars (enum mode *modep)
 
 	case 12:
 	  /* The library search path.  */
-	  if (memcmp (envline, "LIBRARY_PATH", 12) == 0)
+	  if (!__libc_enable_secure
+	      && memcmp (envline, "LIBRARY_PATH", 12) == 0)
 	    {
 	      library_path = &envline[13];
 	      break;
-- 
2.9.3

summary</a><a href='/guix/refs/?id=96a15c65c6c10b1c7595a6d9065aba92234269c5'>refs</a><a class='active' href='/guix/log/gnu/packages/musl.scm'>log</a><a href='/guix/tree/gnu/packages/musl.scm?id=96a15c65c6c10b1c7595a6d9065aba92234269c5'>tree</a><a href='/guix/commit/gnu/packages/musl.scm?id=96a15c65c6c10b1c7595a6d9065aba92234269c5'>commit</a><a href='/guix/diff/gnu/packages/musl.scm?id=96a15c65c6c10b1c7595a6d9065aba92234269c5'>diff</a></td><td class='form'><form class='right' method='get' action='/guix/log/gnu/packages/musl.scm'>
<input type='hidden' name='id' value='96a15c65c6c10b1c7595a6d9065aba92234269c5'/><select name='qt'>
<option value='grep'>log msg</option>
<option value='author'>author</option>
<option value='committer'>committer</option>
<option value='range'>range</option>
</select>
<input class='txt' type='search' size='10' name='q' value=''/>
<input type='submit' value='search'/>
</form>
</td></tr></table>
<div class='path'>path: <a href='/guix/log/?id=96a15c65c6c10b1c7595a6d9065aba92234269c5'>root</a>/<a href='/guix/log/gnu?id=96a15c65c6c10b1c7595a6d9065aba92234269c5'>gnu</a>/<a href='/guix/log/gnu/packages?id=96a15c65c6c10b1c7595a6d9065aba92234269c5'>packages</a>/<a href='/guix/log/gnu/packages/musl.scm?id=96a15c65c6c10b1c7595a6d9065aba92234269c5'>musl.scm</a></div><div class='content'><table class='list nowrap'><tr class='nohover'><th class='left'>Age</th><th class='left'>Commit message (<a href='/guix/log/gnu/packages/musl.scm?id=96a15c65c6c10b1c7595a6d9065aba92234269c5&amp;showmsg=1'>Expand</a>)</th><th class='left'>Author</th></tr>
<tr><td><span title='2019-02-18 18:07:04 +0100'>2019-02-18</span></td><td><a href='/guix/commit/gnu/packages/musl.scm?id=28a6eca368b7c5d14d60ef8575698d42ea978c2b'>gnu: musl: Download sources over HTTPS.</a><span class='msg-avail'>...</span></td><td>Tobias Geerinckx-Rice</td></tr>
<tr><td><span title='2019-02-18 18:07:04 +0100'>2019-02-18</span></td><td><a href='/guix/commit/gnu/packages/musl.scm?id=1bbdcb265a333f03657993eb6602508d95028d2b'>gnu: musl: Don't use NAME in source URI.</a><span class='msg-avail'>...</span></td><td>Tobias Geerinckx-Rice</td></tr>
<tr><td><span title='2019-02-18 18:07:03 +0100'>2019-02-18</span></td><td><a href='/guix/commit/gnu/packages/musl.scm?id=8fdd072bcae7a5cd8bba1c938e831b81c4b59ca1'>gnu: musl: Update to 1.1.21.</a><span class='msg-avail'>...</span></td><td>Tobias Geerinckx-Rice</td></tr>
<tr><td><span title='2018-09-09 15:01:54 +0200'>2018-09-09</span></td><td><a href='/guix/commit/gnu/packages/musl.scm?id=bb105673b88cea5c290ea9a16094ce29fcf0f475'>gnu: musl: Update to 1.1.20.</a><span class='msg-avail'>...</span></td><td>Tobias Geerinckx-Rice</td></tr>
<tr><td><span title='2018-02-23 16:00:04 +0100'>2018-02-23</span></td><td><a href='/guix/commit/gnu/packages/musl.scm?id=78d6524aeb0d04c47582e28710dcc6308af489f7'>gnu: musl: Use HTTPS home page.</a><span class='msg-avail'>...</span></td><td>Tobias Geerinckx-Rice</td></tr>
<tr><td><span title='2018-02-23 16:00:04 +0100'>2018-02-23</span></td><td><a href='/guix/commit/gnu/packages/musl.scm?id=4b971dde8f987c0762d9e5bac9243ce930881376'>gnu: musl: Update to 1.1.19.</a><span class='msg-avail'>...</span></td><td>Tobias Geerinckx-Rice</td></tr>
<tr><td><span title='2017-11-20 18:59:54 -0500'>2017-11-20</span></td><td><a href='/guix/commit/gnu/packages/musl.scm?id=ebde40a14aa3e48f4dd8e2c342452cceca336486'>gnu: musl: Update to 1.1.18.</a><span class='msg-avail'>...</span></td><td>Leo Famulari</td></tr>
<tr><td><span title='2017-10-19 17:37:25 -0400'>2017-10-19</span></td><td><a href='/guix/commit/gnu/packages/musl.scm?id=9ccce799102433b0ae2b480ac0c4f96794808199'>gnu: musl: Update to 1.1.17.</a><span class='msg-avail'>...</span></td><td>Leo Famulari</td></tr>