From f6110a8fee2ca36f8e2d2abecf3cba9fa7b8ea7d Mon Sep 17 00:00:00 2001
From: Florian Weimer <fweimer@redhat.com>
Date: Mon, 19 Jun 2017 17:09:55 +0200
Subject: [PATCH] CVE-2017-1000366: Ignore LD_LIBRARY_PATH for AT_SECURE=1
 programs [BZ #21624]

LD_LIBRARY_PATH can only be used to reorder system search paths, which
is not useful functionality.

This makes an exploitable unbounded alloca in _dl_init_paths unreachable
for AT_SECURE=1 programs.

patch from:
https://sourceware.org/git/?p=glibc.git;a=commit;h=f6110a8fee2ca36f8e2d2abecf3cba9fa7b8ea7d
---
 ChangeLog  | 7 +++++++
 elf/rtld.c | 3 ++-
 2 files changed, 9 insertions(+), 1 deletion(-)

diff --git a/elf/rtld.c b/elf/rtld.c
index 2446a87..2269dbe 100644
--- a/elf/rtld.c
+++ b/elf/rtld.c
@@ -2422,7 +2422,8 @@ process_envvars (enum mode *modep)
 
 	case 12:
 	  /* The library search path.  */
-	  if (memcmp (envline, "LIBRARY_PATH", 12) == 0)
+	  if (!__libc_enable_secure
+	      && memcmp (envline, "LIBRARY_PATH", 12) == 0)
 	    {
 	      library_path = &envline[13];
 	      break;
-- 
2.9.3

mmary</a><a href='/guix/refs/?id=7273b3b2a666b470fe508ae3221d9b93b60a4f15'>refs</a><a class='active' href='/guix/log/gnu/packages/moe.scm'>log</a><a href='/guix/tree/gnu/packages/moe.scm?id=7273b3b2a666b470fe508ae3221d9b93b60a4f15'>tree</a><a href='/guix/commit/gnu/packages/moe.scm?id=7273b3b2a666b470fe508ae3221d9b93b60a4f15'>commit</a><a href='/guix/diff/gnu/packages/moe.scm?id=7273b3b2a666b470fe508ae3221d9b93b60a4f15'>diff</a></td><td class='form'><form class='right' method='get' action='/guix/log/gnu/packages/moe.scm'>
<input type='hidden' name='id' value='7273b3b2a666b470fe508ae3221d9b93b60a4f15'/><select name='qt'>
<option value='grep'>log msg</option>
<option value='author'>author</option>
<option value='committer'>committer</option>
<option value='range'>range</option>
</select>
<input class='txt' type='search' size='10' name='q' value=''/>
<input type='submit' value='search'/>
</form>
</td></tr></table>
<div class='path'>path: <a href='/guix/log/?id=7273b3b2a666b470fe508ae3221d9b93b60a4f15'>root</a>/<a href='/guix/log/gnu?id=7273b3b2a666b470fe508ae3221d9b93b60a4f15'>gnu</a>/<a href='/guix/log/gnu/packages?id=7273b3b2a666b470fe508ae3221d9b93b60a4f15'>packages</a>/<a href='/guix/log/gnu/packages/moe.scm?id=7273b3b2a666b470fe508ae3221d9b93b60a4f15'>moe.scm</a></div><div class='content'><table class='list nowrap'><tr class='nohover'><th class='left'>Age</th><th class='left'>Commit message (<a href='/guix/log/gnu/packages/moe.scm?id=7273b3b2a666b470fe508ae3221d9b93b60a4f15&amp;showmsg=1'>Expand</a>)</th><th class='left'>Author</th></tr>
<tr><td><span title='2019-01-06 15:42:06 +0200'>2019-01-06</span></td><td><a href='/guix/commit/gnu/packages/moe.scm?id=644353d80d9b6b6f8c2b91fcdbb97c0288882e9d'>gnu: moe: Update to 1.10.</a><span class='msg-avail'>...<span class='msg-tooltip'>* gnu/packages/moe.scm (moe): Update to 1.10.
[license]: Fix license, gpl2+.
</span></span></td><td>Efraim Flashner</td></tr>