This patch is adapted from commit a11f47475e6443b7f32d21f2271f28f417e2ac04 and
fixes CVE-2018-5711.

From a11f47475e6443b7f32d21f2271f28f417e2ac04 Mon Sep 17 00:00:00 2001
From: "Christoph M. Becker" <cmbecker69@gmx.de>
Date: Wed, 29 Nov 2017 19:37:38 +0100
Subject: [PATCH] Fix #420: Potential infinite loop in gdImageCreateFromGifCtx

Due to a signedness confusion in `GetCode_` a corrupt GIF file can
trigger an infinite loop.  Furthermore we make sure that a GIF without
any palette entries is treated as invalid *after* open palette entries
have been removed.

CVE-2018-5711

See also https://bugs.php.net/bug.php?id=75571.
---
 src/gd_gif_in.c             |  12 ++++++------
 1 file changed, 38 insertions(+), 6 deletions(-)

diff --git a/src/gd_gif_in.c b/src/gd_gif_in.c
index daf26e7..0a8bd71 100644
--- a/src/gd_gif_in.c
+++ b/src/gd_gif_in.c
@@ -335,11 +335,6 @@ terminated:
 		return 0;
 	}
 
-	if(!im->colorsTotal) {
-		gdImageDestroy(im);
-		return 0;
-	}
-
 	/* Check for open colors at the end, so
 	 * we can reduce colorsTotal and ultimately
 	 * BitsPerPixel */
@@ -351,6 +346,11 @@ terminated:
 		}
 	}
 
+	if(!im->colorsTotal) {
+		gdImageDestroy(im);
+		return 0;
+	}
+
 	return im;
 }
 
@@ -447,7 +447,7 @@ static int
 GetCode_(gdIOCtx *fd, CODE_STATIC_DATA *scd, int code_size, int flag, int *ZeroDataBlockP)
 {
 	int i, j, ret;
-	unsigned char count;
+	int count;
 
 	if(flag) {
 		scd->curbit = 0;

-- 
2.13.6

466dac2e9b09b94b3f776a95ecd'>diff</a></td><td class='form'><form class='right' method='get' action='/guix/log/gnu/tests.scm'>
<input type='hidden' name='id' value='b456e296dc401466dac2e9b09b94b3f776a95ecd'/><select name='qt'>
<option value='grep'>log msg</option>
<option value='author'>author</option>
<option value='committer'>committer</option>
<option value='range'>range</option>
</select>
<input class='txt' type='search' size='10' name='q' value=''/>
<input type='submit' value='search'/>
</form>
</td></tr></table>
<div class='path'>path: <a href='/guix/log/?id=b456e296dc401466dac2e9b09b94b3f776a95ecd'>root</a>/<a href='/guix/log/gnu?id=b456e296dc401466dac2e9b09b94b3f776a95ecd'>gnu</a>/<a href='/guix/log/gnu/tests.scm?id=b456e296dc401466dac2e9b09b94b3f776a95ecd'>tests.scm</a></div><div class='content'><table class='list nowrap'><tr class='nohover'><th class='left'>Age</th><th class='left'>Commit message (<a href='/guix/log/gnu/tests.scm?id=b456e296dc401466dac2e9b09b94b3f776a95ecd&amp;showmsg=1'>Expand</a>)</th><th class='left'>Author</th></tr>
<tr><td><span title='2023-11-05 23:23:23 +0100'>2023-11-05</span></td><td><a href='/guix/commit/gnu/tests.scm?id=0c695bbf8dbd5a5c1224f331a78b6316bc16e4d1'>tests: Honor system and target when lowering &lt;system-test&gt;.</a><span class='msg-avail'>...<span class='msg-tooltip'>* gnu/tests.scm (compile-system-test): Wrap ‘system-test-value’ call in
‘mparameterize’.

Change-Id: I4be28913a86f43059b0886ad2fcf81a9c699b730
</span></span></td><td>Ludovic Courtès</td></tr>
<tr><td><span title='2023-04-21 16:16:38 +0200'>2023-04-21</span></td><td><a href='/guix/commit/gnu/tests.scm?id=a09c7da8f8d8e732f969cf0a09aaa78f87032ab1'>tests: Fork and exec a new Guile for the marionette REPL.</a><span class='msg-avail'>...<span class='msg-tooltip'>By merely forking PID 1, details from PID 1 (shepherd) would leak into
the marionette process, such as the set of modules in scope and state
inherited from the shepherd process (&lt;service&gt; instances, fibers,
etc.).  Running a fresh Guile instance avoids that.

* gnu/tests.scm (marionette-program): New procedure.
(marionette-shepherd-service): Change 'start' to use
'make-forkexec-constructor', and run the result of 'marionette-program'.
</span></span></td><td>Ludovic Courtès</td></tr>