From: Debian Science Maintainers
 <debian-science-maintainers@lists.alioth.debian.org>
Date: Mon, 10 Oct 2016 08:22:44 +0100
Subject: CVE-2016-5684

---
 Source/FreeImage/PluginXPM.cpp | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/Source/FreeImage/PluginXPM.cpp b/Source/FreeImage/PluginXPM.cpp
index a698321..cc7bd07 100644
--- a/Source/FreeImage/PluginXPM.cpp
+++ b/Source/FreeImage/PluginXPM.cpp
@@ -181,6 +181,11 @@ Load(FreeImageIO *io, fi_handle handle, int page, int flags, void *data) {
 		}
 		free(str);
 
+		// check info string
+		if((width <= 0) || (height <= 0) || (colors <= 0) || (cpp <= 0)) {
+			throw "Improperly formed info string";
+		}
+
         if (colors > 256) {
 			dib = FreeImage_AllocateHeader(header_only, width, height, 24, FI_RGBA_RED_MASK, FI_RGBA_GREEN_MASK, FI_RGBA_BLUE_MASK);
 		} else {
@@ -193,7 +198,7 @@ Load(FreeImageIO *io, fi_handle handle, int page, int flags, void *data) {
 			FILE_RGBA rgba;
 
 			str = ReadString(io, handle);
-			if(!str)
+			if(!str || (strlen(str) < (size_t)cpp))
 				throw "Error reading color strings";
 
 			std::string chrs(str,cpp); //create a string for the color chars using the first cpp chars
/guix-manual.fr.po'>log</a><a href='/guix/tree/po/doc/guix-manual.fr.po?id=dbeef44f3c520816251bde74c1005915a637e1ef'>tree</a><a href='/guix/commit/po/doc/guix-manual.fr.po?id=dbeef44f3c520816251bde74c1005915a637e1ef'>commit</a><a href='/guix/diff/po/doc/guix-manual.fr.po?id=dbeef44f3c520816251bde74c1005915a637e1ef'>diff</a></td><td class='form'><form class='right' method='get' action='/guix/log/po/doc/guix-manual.fr.po'>
<input type='hidden' name='id' value='dbeef44f3c520816251bde74c1005915a637e1ef'/><select name='qt'>
<option value='grep'>log msg</option>
<option value='author'>author</option>
<option value='committer'>committer</option>
<option value='range'>range</option>
</select>
<input class='txt' type='search' size='10' name='q' value=''/>
<input type='submit' value='search'/>
</form>
</td></tr></table>
<div class='path'>path: <a href='/guix/log/?id=dbeef44f3c520816251bde74c1005915a637e1ef'>root</a>/<a href='/guix/log/po?id=dbeef44f3c520816251bde74c1005915a637e1ef'>po</a>/<a href='/guix/log/po/doc?id=dbeef44f3c520816251bde74c1005915a637e1ef'>doc</a>/<a href='/guix/log/po/doc/guix-manual.fr.po?id=dbeef44f3c520816251bde74c1005915a637e1ef'>guix-manual.fr.po</a></div><div class='content'><table class='list nowrap'><tr class='nohover'><th class='left'>Age</th><th class='left'>Commit message (<a href='/guix/log/po/doc/guix-manual.fr.po?id=dbeef44f3c520816251bde74c1005915a637e1ef&amp;showmsg=1'>Expand</a>)</th><th class='left'>Author</th></tr>
<tr><td><span title='2024-05-01 02:42:54 +0200'>2024-05-01</span></td><td><a href='/guix/commit/po/doc/guix-manual.fr.po?id=8bf41c80ef13ea57e834f4e23d649bd99a3e08fc'>nls: Update translations.</a><span class='msg-avail'>...</span></td><td>Florian Pelz</td></tr>
<tr><td><span title='2024-02-29 22:57:09 +0100'>2024-02-29</span></td><td><a href='/guix/commit/po/doc/guix-manual.fr.po?id=956f44b931f050fbffca51737000b9049808b3ca'>nls: Update translations.</a><span class='msg-avail'>...</span></td><td>Florian Pelz</td></tr>
<tr><td><span title='2024-02-01 18:34:22 +0100'>2024-02-01</span></td><td><a href='/guix/commit/po/doc/guix-manual.fr.po?id=6f78803b01d416ab421ba860751b764b9e4f33db'>nls: Update translations.</a><span class='msg-avail'>...</span></td><td>Florian Pelz</td></tr>
<tr><td><span title='2024-01-01 00:45:47 +0100'>2024-01-01</span></td><td><a href='/guix/commit/po/doc/guix-manual.fr.po?id=86b5fa100992527c434616482ba9cfd92b636d12'>nls: Update translations.</a><span class='msg-avail'>...</span></td><td>Florian Pelz</td></tr>
<tr><td><span title='2023-10-31 23:01:37 +0100'>2023-10-31</span></td><td><a href='/guix/commit/po/doc/guix-manual.fr.po?id=938a47c86d7bea785f33f42834c5c1f3dfa594b0'>nls: Update translations.</a><span class='msg-avail'>...</span></td><td>Florian Pelz</td></tr>