From 6e8cb6f2175cd5c108de615a970a27877adfaea0 Mon Sep 17 00:00:00 2001
From: Maxim Cournoyer <maxim.cournoyer@gmail.com>
Date: Fri, 19 Jan 2024 10:49:51 -0500
Subject: [PATCH] tests: Fix byte-compilation test.

* test/shx-test.el (shx-test-unit-byte-compile): Simply assert on the
return value of byte-compile-file, which is non-nil when there are no
errors.

Fixes: <https://github.com/riscy/shx-for-emacs/issues/33>
---
 test/shx-test.el | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/test/shx-test.el b/test/shx-test.el
index e18cefb..ed5aee3 100644
--- a/test/shx-test.el
+++ b/test/shx-test.el
@@ -83,10 +83,8 @@ Example:
   "Test byte-compilation against the shx.el file."
   (ignore-errors (kill-buffer "*Compile-Log*"))
   (let ((file (replace-regexp-in-string ".elc$" ".el" (symbol-file 'shx-mode))))
-    (byte-compile-file file)
     (shx-test-assert "shx.el passes byte-compilation"
-                     (with-current-buffer (get-buffer-create "*Compile-Log*")
-                       (<= (- (point-max) (point)) 3)))))
+                     (byte-compile-file file))))
 
 (defun shx-test-unit-declare-function ()
   "Test `declare-function'."

base-commit: b99d16f36bc278d668d8428c4bc9af77064c336a
-- 
2.41.0

mit/NEWS?id=5a1b2467361edcf8f2f9c7399658b4e136e979d4'>commit</a><a href='/guix/diff/NEWS?id=5a1b2467361edcf8f2f9c7399658b4e136e979d4'>diff</a></td><td class='form'><form class='right' method='get' action='/guix/log/NEWS'>
<input type='hidden' name='id' value='5a1b2467361edcf8f2f9c7399658b4e136e979d4'/><select name='qt'>
<option value='grep'>log msg</option>
<option value='author'>author</option>
<option value='committer'>committer</option>
<option value='range'>range</option>
</select>
<input class='txt' type='search' size='10' name='q' value=''/>
<input type='submit' value='search'/>
</form>
</td></tr></table>
<div class='path'>path: <a href='/guix/log/?id=5a1b2467361edcf8f2f9c7399658b4e136e979d4'>root</a>/<a href='/guix/log/NEWS?id=5a1b2467361edcf8f2f9c7399658b4e136e979d4'>NEWS</a></div><div class='content'><table class='list nowrap'><tr class='nohover'><th class='left'>Age</th><th class='left'>Commit message (<a href='/guix/log/NEWS?id=5a1b2467361edcf8f2f9c7399658b4e136e979d4&amp;showmsg=1'>Expand</a>)</th><th class='left'>Author</th></tr>
<tr><td><span title='2023-03-28 20:13:59 -0400'>2023-03-28</span></td><td><a href='/guix/commit/NEWS?id=c94a7d41c76f520e56a1304bd7fb3cbf3579fc52'>NEWS: Mention new rpm format.</a><span class='msg-avail'>...<span class='msg-tooltip'>* NEWS (Package management): Mention new rpm format.
</span></span></td><td>Maxim Cournoyer</td></tr>
<tr><td><span title='2022-12-18 01:17:15 +0100'>2022-12-18</span></td><td><a href='/guix/commit/NEWS?id=a8f9579348aae58b68b25004cfd28aa7407db802'>Update NEWS.</a></td><td>Ludovic Courtès</td></tr>
<tr><td><span title='2022-12-17 19:15:50 +0100'>2022-12-17</span></td><td><a href='/guix/commit/NEWS?id=239bfe2ec1fa3b4305500211e6cade6e4bda2a62'>Update NEWS.</a></td><td>Marius Bakke</td></tr>
<tr><td><span title='2022-12-02 23:20:54 +0100'>2022-12-02</span></td><td><a href='/guix/commit/NEWS?id=7ef490e3fc94e0b9025c98797fc014f07e21c4cc'>Update NEWS.</a></td><td>Ludovic Courtès</td></tr>
<tr><td><span title='2022-11-23 17:22:11 +0100'>2022-11-23</span></td><td><a href='/guix/commit/NEWS?id=7a2082023ad9c7479bfedf39537606a088222d48'>NEWS: Update it.</a><span class='msg-avail'>...<span class='msg-tooltip'>* NEWS: Shepherd is already at 0.9.3 now.
</span></span></td><td>Jonathan Brielmaier</td></tr>
<tr><td><span title='2022-11-16 14:28:09 -0500'>2022-11-16</span></td><td><a href='/guix/commit/NEWS?id=e06df550e21d596b65dc3e5b3e99152be58372b3'>Update NEWS.</a></td><td>Maxim Cournoyer</td></tr>
<tr><td><span title='2022-10-13 10:49:19 +0200'>2022-10-13</span></td><td><a href='/guix/commit/NEWS?id=d2ca9334a304ab5837b62968b77bbbab34af7afe'>NEWS: Update it.</a><span class='msg-avail'>...<span class='msg-tooltip'>* NEWS: Add an entry about 'guix shell' --emulate-fhs option.
</span></span></td><td>Mathieu Othacehe</td></tr>
<tr><td><span title='2022-10-07 10:11:13 -0400'>2022-10-07</span></td><td><a href='/guix/commit/NEWS?id=6e3dab4737832a78de07dd805a4057eb5f4cfcf3'>Update NEWS.</a><span class='msg-avail'>...<span class='msg-tooltip'>* NEWS: Add new entry for installation script improvements.
</span></span></td><td>Maxim Cournoyer</td></tr>