From: Tobias Geerinckx-Rice Date: Sun, 16 Jun 2019 02:36:23 +0200 Subject: [PATCH] gnu: dstat: Skip devices without I/O. Taken verbatim from a pull request[0] that will never be merged. [0]: https://github.com/dagwieers/dstat/pull/164 From 0988589ea4ee092b285bd4049d56add5f61e3f69 Mon Sep 17 00:00:00 2001 From: Tobias Gruetzmacher Date: Fri, 15 Feb 2019 18:46:57 +0100 Subject: [PATCH] Skip devices without I/O Linux 4.18+ has added more fields to the diskstats proc file, so the original skip condition for devices without I/O didn't apply anymore. --- dstat | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/dstat b/dstat index 9359965..5c2fb53 100755 --- a/dstat +++ b/dstat @@ -763,7 +763,7 @@ class dstat_disk(dstat): ret = [] for l in self.splitlines(): if len(l) < 13: continue - if l[3:] == ['0',] * 11: continue + if l[3:] == ['0',] * (len(l) - 3): continue name = l[2] ret.append(name) for item in objlist: ret.append(item) fs/?id=39ad23ec9a8625eae3d23618e902e83608476b36'>refslogtreecommitdiff
path: root/nix/libstore/gc.cc
AgeCommit message (Expand)Author
2021-11-16daemon: Do not deduplicate files smaller than 8 KiB....Files smaller than 8 KiB typically represent ~70% of the entries in /gnu/store/.links but only contribute to ~4% of the space savings afforded by deduplication. Not considering these files for deduplication speeds up file insertion in the store and, more importantly, leaves 'removeUnusedLinks' with fewer entries to traverse, thereby speeding it up proportionally. Partly fixes <https://issues.guix.gnu.org/24937>. * config-daemon.ac: Remove symlink hard link check and CAN_LINK_SYMLINK definition. * guix/store/deduplication.scm (%deduplication-minimum-size): New variable. (deduplicate)[loop]: Do not recurse when FILE's size is below %DEDUPLICATION-MINIMUM-SIZE. (dump-port): New procedure. (dump-file/deduplicate)[hash]: Turn into... [dump-and-compute-hash]: ... this thunk. Call 'deduplicate' only when SIZE is greater than %DEDUPLICATION-MINIMUM-SIZE; otherwise call 'dump-port'. * nix/libstore/gc.cc (LocalStore::removeUnusedLinks): Drop files where st.st_size < deduplicationMinSize. * nix/libstore/local-store.hh (deduplicationMinSize): New declaration. * nix/libstore/optimise-store.cc (deduplicationMinSize): New variable. (LocalStore::optimisePath_): Return when PATH is a symlink or smaller than 'deduplicationMinSize'. * tests/derivations.scm ("identical files are deduplicated"): Produce files bigger than %DEDUPLICATION-MINIMUM-SIZE. * tests/nar.scm ("restore-file-set with directories (signed, valid)"): Likewise. * tests/store-deduplication.scm ("deduplicate, below %deduplication-minimum-size"): New test. ("deduplicate", "deduplicate, ENOSPC"): Produce files bigger than %DEDUPLICATION-MINIMUM-SIZE. * tests/store.scm ("substitute, deduplication"): Likewise. Ludovic Courtès