From dcc9f51cbd4ed622cfb0f9b1c141eb2ffe3b12f1 Mon Sep 17 00:00:00 2001
From: Quanah Gibson-Mount <quanah@symas.com>
Date: Tue, 18 Feb 2020 19:05:12 +0000
Subject: [PATCH] Fix #587

Off by one error in common.c, CVE-2019-19906.

Thanks to Stephan Zeisberg for reporting
---
 lib/common.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lib/common.c b/lib/common.c
index bc3bf1df..9969d6aa 100644
--- a/lib/common.c
+++ b/lib/common.c
@@ -190,7 +190,7 @@ int _sasl_add_string(char **out, size_t *alloclen,
 
   if (add==NULL) add = "(null)";
 
-  addlen=strlen(add); /* only compute once */
+  addlen=strlen(add)+1; /* only compute once */
   if (_buf_alloc(out, alloclen, (*outlen)+addlen)!=SASL_OK)
     return SASL_NOMEM;
 
ed='selected'>koszko</option>
<option value='koszko-scripts'>koszko-scripts</option>
</select> <input type='submit' value='switch'/></form></td></tr>
<tr><td class='sub'>Wojtek's customized Guix</td><td class='sub right'></td></tr></table>
<table class='tabs'><tr><td>
<a href='/guix/about/'>about</a><a href='/guix/'>summary</a><a href='/guix/refs/?id=23290064c294a254ffa38ba0b772231087e01c54'>refs</a><a class='active' href='/guix/log/po/packages/LINGUAS'>log</a><a href='/guix/tree/po/packages/LINGUAS?id=23290064c294a254ffa38ba0b772231087e01c54'>tree</a><a href='/guix/commit/po/packages/LINGUAS?id=23290064c294a254ffa38ba0b772231087e01c54'>commit</a><a href='/guix/diff/po/packages/LINGUAS?id=23290064c294a254ffa38ba0b772231087e01c54'>diff</a></td><td class='form'><form class='right' method='get' action='/guix/log/po/packages/LINGUAS'>
<input type='hidden' name='id' value='23290064c294a254ffa38ba0b772231087e01c54'/><select name='qt'>
<option value='grep'>log msg</option>
<option value='author'>author</option>
<option value='committer'>committer</option>
<option value='range'>range</option>
</select>
<input class='txt' type='search' size='10' name='q' value=''/>
<input type='submit' value='search'/>
</form>
</td></tr></table>
<div class='path'>path: <a href='/guix/log/?id=23290064c294a254ffa38ba0b772231087e01c54'>root</a>/<a href='/guix/log/po?id=23290064c294a254ffa38ba0b772231087e01c54'>po</a>/<a href='/guix/log/po/packages?id=23290064c294a254ffa38ba0b772231087e01c54'>packages</a>/<a href='/guix/log/po/packages/LINGUAS?id=23290064c294a254ffa38ba0b772231087e01c54'>LINGUAS</a></div><div class='content'><table class='list nowrap'><tr class='nohover'><th class='left'>Age</th><th class='left'>Commit message (<a href='/guix/log/po/packages/LINGUAS?id=23290064c294a254ffa38ba0b772231087e01c54&amp;showmsg=1'>Expand</a>)</th><th class='left'>Author</th></tr>
<tr><td><span title='2015-12-06 23:02:32 +0100'>2015-12-06</span></td><td><a href='/guix/commit/po/packages/LINGUAS?id=91726b6a3b1b0f1d87d0fb76f55173f8662724a4'>nls: Add Polish translation.</a></td><td>Ludovic Courtès</td></tr>
<tr><td><span title='2015-11-01 22:24:20 +0100'>2015-11-01</span></td><td><a href='/guix/commit/po/packages/LINGUAS?id=b8d2eda4a37a7e4c9fb529bd48899d87cefaf345'>nls: Add Danish translation for packages.</a></td><td>Ludovic Courtès</td></tr>
<tr><td><span title='2014-12-26 23:28:13 +0100'>2014-12-26</span></td><td><a href='/guix/commit/po/packages/LINGUAS?id=bf7688fe4d8624ed9bddc8f7f3887df5f1fc3957'>nls: Add French translation for packages.</a></td><td>Ludovic Courtès</td></tr>
<tr><td><span title='2014-12-03 22:52:19 +0100'>2014-12-03</span></td><td><a href='/guix/commit/po/packages/LINGUAS?id=845d48e7a1a9068e1d6df0c1e0294633c05b7c7e'>nls: Add Hungarian translation.</a><span class='msg-avail'>...<span class='msg-tooltip'>* po/packages/hu.po: New file.
* po/packages/LINGUAS: Add it.
</span></span></td><td>Ludovic Courtès</td></tr>