From dcc9f51cbd4ed622cfb0f9b1c141eb2ffe3b12f1 Mon Sep 17 00:00:00 2001
From: Quanah Gibson-Mount <quanah@symas.com>
Date: Tue, 18 Feb 2020 19:05:12 +0000
Subject: [PATCH] Fix #587

Off by one error in common.c, CVE-2019-19906.

Thanks to Stephan Zeisberg for reporting
---
 lib/common.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lib/common.c b/lib/common.c
index bc3bf1df..9969d6aa 100644
--- a/lib/common.c
+++ b/lib/common.c
@@ -190,7 +190,7 @@ int _sasl_add_string(char **out, size_t *alloclen,
 
   if (add==NULL) add = "(null)";
 
-  addlen=strlen(add); /* only compute once */
+  addlen=strlen(add)+1; /* only compute once */
   if (_buf_alloc(out, alloclen, (*outlen)+addlen)!=SASL_OK)
     return SASL_NOMEM;
 
lected'>koszko</option>
<option value='koszko-scripts'>koszko-scripts</option>
</select> <input type='submit' value='switch'/></form></td></tr>
<tr><td class='sub'>Wojtek's customized Guix</td><td class='sub right'></td></tr></table>
<table class='tabs'><tr><td>
<a href='/guix/about/'>about</a><a href='/guix/'>summary</a><a href='/guix/refs/?id=999783b92d549dfd53a305ad744fcc0048fa2479'>refs</a><a class='active' href='/guix/log/gnu/packages.scm'>log</a><a href='/guix/tree/gnu/packages.scm?id=999783b92d549dfd53a305ad744fcc0048fa2479'>tree</a><a href='/guix/commit/gnu/packages.scm?id=999783b92d549dfd53a305ad744fcc0048fa2479'>commit</a><a href='/guix/diff/gnu/packages.scm?id=999783b92d549dfd53a305ad744fcc0048fa2479'>diff</a></td><td class='form'><form class='right' method='get' action='/guix/log/gnu/packages.scm'>
<input type='hidden' name='id' value='999783b92d549dfd53a305ad744fcc0048fa2479'/><select name='qt'>
<option value='grep'>log msg</option>
<option value='author'>author</option>
<option value='committer'>committer</option>
<option value='range'>range</option>
</select>
<input class='txt' type='search' size='10' name='q' value=''/>
<input type='submit' value='search'/>
</form>
</td></tr></table>
<div class='path'>path: <a href='/guix/log/?id=999783b92d549dfd53a305ad744fcc0048fa2479'>root</a>/<a href='/guix/log/gnu?id=999783b92d549dfd53a305ad744fcc0048fa2479'>gnu</a>/<a href='/guix/log/gnu/packages.scm?id=999783b92d549dfd53a305ad744fcc0048fa2479'>packages.scm</a></div><div class='content'><table class='list nowrap'><tr class='nohover'><th class='left'>Age</th><th class='left'>Commit message (<a href='/guix/log/gnu/packages.scm?id=999783b92d549dfd53a305ad744fcc0048fa2479&amp;showmsg=1'>Expand</a>)</th><th class='left'>Author</th></tr>
<tr><td><span title='2022-06-06 22:43:30 +0200'>2022-06-06</span></td><td><a href='/guix/commit/gnu/packages.scm?id=635d49f97ee233bbb2673f97d7556c3c91b55889'>packages: Use SRFI-71 instead of SRFI-11.</a><span class='msg-avail'>...<span class='msg-tooltip'>* gnu/packages.scm (%package-module-path): Use 'let*' instead of
'let*-values'.
(specification-&gt;package, specification-&gt;location)
(specification-&gt;package+output): Use 'let' instead of 'let-values'.
</span></span></td><td>Ludovic Courtès</td></tr>
<tr><td><span title='2022-06-06 22:43:30 +0200'>2022-06-06</span></td><td><a href='/guix/commit/gnu/packages.scm?id=7041fe0646a9603e7d1d6bde139a284146515917'>packages: Add 'specifications-&gt;packages'.</a><span class='msg-avail'>...<span class='msg-tooltip'>* gnu/packages.scm (specifications-&gt;packages): New procedure.
* guix/scripts/home/import.scm (manifest+configuration-files-&gt;code): Use it.
* tests/home-import.scm (match-home-environment-no-services)
(match-home-environment-no-services-nor-packages)
(match-home-environment-bash-service)
(match-home-environment-bash-service-with-alias): Adjust 'packages'
field accordingly.

Co-authored-by: Ludovic Courtès &lt;ludo@gnu.org&gt;
</span></span></td><td>Antero Mejr</td></tr>
<tr><td><span title='2022-04-04 22:58:03 +0200'>2022-04-04</span></td><td><a href='/guix/commit/gnu/packages.scm?id=f54f2aa9df5047b348ca104f5145af50c1a482f6'>packages: Add 'package-unique-version-prefix'.</a><span class='msg-avail'>...<span class='msg-tooltip'>* gnu/packages.scm (package-unique-version-prefix): New procedure.
* guix/scripts/package.scm (manifest-entry-version-prefix): Use it.
* tests/packages.scm ("package-unique-version-prefix, gcc@8")
("package-unique-version-prefix, grep"): New tests.
</span></span></td><td>Ludovic Courtès</td></tr>
<tr><td><span title='2022-01-11 20:34:59 +0100'>2022-01-11</span></td><td><a href='/guix/commit/gnu/packages.scm?id=0552dcb294bbfed76d7a495f5e368c53f20b852a'>shell: Cache profiles even when using package specs.</a><span class='msg-avail'>...<span class='msg-tooltip'>This enables profile caching not just when '-m' or '-f' is used, but
also when package specs are passed on the command line, as in:

  guix shell -D guix git

It also changes profile cache keys to include the system type, which was
previously ignored.

* guix/scripts/shell.scm (options-with-caching)[single-file-for-caching]:
Remove.
Call 'profile-cached-gc-root' instead; adjust to accept two values.
(profile-cache-primary-key): New procedure.
(profile-cache-key): Remove.
(profile-file-cache-key, profile-spec-cache-key): New procedures.
(profile-cached-gc-root): Rewrite to include functionality formally in
'single-file-for-caching', but extend to handle package specs.
* gnu/packages.scm (cache-is-authoritative?): Export.
* guix/transformations.scm (transformation-option-key?): New procedure.
* doc/guix.texi (Invoking guix shell): Move '--rebuild-cache'
documentation to the bottom, just above '--root'.  Explain caching and
how these two options relate to that.
</span></span></td><td>Ludovic Courtès</td></tr>