From dcc9f51cbd4ed622cfb0f9b1c141eb2ffe3b12f1 Mon Sep 17 00:00:00 2001
From: Quanah Gibson-Mount <quanah@symas.com>
Date: Tue, 18 Feb 2020 19:05:12 +0000
Subject: [PATCH] Fix #587

Off by one error in common.c, CVE-2019-19906.

Thanks to Stephan Zeisberg for reporting
---
 lib/common.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lib/common.c b/lib/common.c
index bc3bf1df..9969d6aa 100644
--- a/lib/common.c
+++ b/lib/common.c
@@ -190,7 +190,7 @@ int _sasl_add_string(char **out, size_t *alloclen,
 
   if (add==NULL) add = "(null)";
 
-  addlen=strlen(add); /* only compute once */
+  addlen=strlen(add)+1; /* only compute once */
   if (_buf_alloc(out, alloclen, (*outlen)+addlen)!=SASL_OK)
     return SASL_NOMEM;
 
cted='selected'>koszko</option>
<option value='koszko-scripts'>koszko-scripts</option>
</select> <input type='submit' value='switch'/></form></td></tr>
<tr><td class='sub'>Wojtek's customized Guix</td><td class='sub right'></td></tr></table>
<table class='tabs'><tr><td>
<a href='/guix/about/'>about</a><a href='/guix/'>summary</a><a href='/guix/refs/?id=3825b44448e1ba60b16b4169bdab391755297cfb'>refs</a><a class='active' href='/guix/log/po/packages/pt_BR.po'>log</a><a href='/guix/tree/po/packages/pt_BR.po?id=3825b44448e1ba60b16b4169bdab391755297cfb'>tree</a><a href='/guix/commit/po/packages/pt_BR.po?id=3825b44448e1ba60b16b4169bdab391755297cfb'>commit</a><a href='/guix/diff/po/packages/pt_BR.po?id=3825b44448e1ba60b16b4169bdab391755297cfb'>diff</a></td><td class='form'><form class='right' method='get' action='/guix/log/po/packages/pt_BR.po'>
<input type='hidden' name='id' value='3825b44448e1ba60b16b4169bdab391755297cfb'/><select name='qt'>
<option value='grep'>log msg</option>
<option value='author'>author</option>
<option value='committer'>committer</option>
<option value='range'>range</option>
</select>
<input class='txt' type='search' size='10' name='q' value=''/>
<input type='submit' value='search'/>
</form>
</td></tr></table>
<div class='path'>path: <a href='/guix/log/?id=3825b44448e1ba60b16b4169bdab391755297cfb'>root</a>/<a href='/guix/log/po?id=3825b44448e1ba60b16b4169bdab391755297cfb'>po</a>/<a href='/guix/log/po/packages?id=3825b44448e1ba60b16b4169bdab391755297cfb'>packages</a>/<a href='/guix/log/po/packages/pt_BR.po?id=3825b44448e1ba60b16b4169bdab391755297cfb'>pt_BR.po</a></div><div class='content'><table class='list nowrap'><tr class='nohover'><th class='left'>Age</th><th class='left'>Commit message (<a href='/guix/log/po/packages/pt_BR.po?id=3825b44448e1ba60b16b4169bdab391755297cfb&amp;showmsg=1'>Expand</a>)</th><th class='left'>Author</th></tr>
ge</th><th class='left'>Commit message (<a href='/guix/log/gnu/installer/newt/timezone.scm?id=08df30f232afc1fc1ae7fb3c9889b5ad96bc5dea&amp;showmsg=1'>Expand</a>)</th><th class='left'>Author</th></tr>
<tr><td><span title='2022-02-02 16:46:44 +0100'>2022-02-02</span></td><td><a href='/guix/commit/gnu/installer/newt/timezone.scm?id=726d0bd2f36363392ba2fcefd6e5d4aeed27dc9e'>installer: Use named prompt to abort or break installer steps.</a><span class='msg-avail'>...<span class='msg-tooltip'>* gnu/installer/steps.scm (run-installer-steps): Set up
'installer-step prompt.
* gnu/installer/newt/ethernet.scm (run-ethernet-page)
* gnu/installer/newt/final.scm (run-config-display-page,
run-install-failed-page)
* gnu/installer/newt/keymap.scm (run-layout-page, run-variant-page)
* gnu/installer/newt/locale.scm (run-language-page,
run-territory-page, run-codeset-page, run-modifier-page,
run-locale-page)
* gnu/installer/newt/network.scm (run-technology-page,
wait-service-online)
* gnu/installer/newt/page.scm (run-listbox-selection-page,
run-checkbox-tree-page)
* gnu/installer/newt/partition.scm (button-exit-action)
* gnu/installer/newt/services.scm (run-desktop-environments-cbt-page,
run-networking-cbt-page, run-other-services-cbt-page,
run-network-management-page)
* gnu/installer/newt/timezone.scm (run-timezone-page)
* gnu/installer/newt/user.scm (run-user-page)
* gnu/installer/newt/welcome.scm (run-menu-page)
* gnu/installer/newt/wifi.scm (run-wifi-page): Use the 'installer-step
prompt to abort.

Signed-off-by: Mathieu Othacehe &lt;othacehe@gnu.org&gt;
</span></span></td><td>Josselin Poiret</td></tr>