From dcc9f51cbd4ed622cfb0f9b1c141eb2ffe3b12f1 Mon Sep 17 00:00:00 2001
From: Quanah Gibson-Mount <quanah@symas.com>
Date: Tue, 18 Feb 2020 19:05:12 +0000
Subject: [PATCH] Fix #587

Off by one error in common.c, CVE-2019-19906.

Thanks to Stephan Zeisberg for reporting
---
 lib/common.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lib/common.c b/lib/common.c
index bc3bf1df..9969d6aa 100644
--- a/lib/common.c
+++ b/lib/common.c
@@ -190,7 +190,7 @@ int _sasl_add_string(char **out, size_t *alloclen,
 
   if (add==NULL) add = "(null)";
 
-  addlen=strlen(add); /* only compute once */
+  addlen=strlen(add)+1; /* only compute once */
   if (_buf_alloc(out, alloclen, (*outlen)+addlen)!=SASL_OK)
     return SASL_NOMEM;
 
ko</option>
<option value='koszko-scripts'>koszko-scripts</option>
</select> <input type='submit' value='switch'/></form></td></tr>
<tr><td class='sub'>Wojtek's customized Guix</td><td class='sub right'></td></tr></table>
<table class='tabs'><tr><td>
<a href='/guix/about/'>about</a><a href='/guix/'>summary</a><a href='/guix/refs/?id=0513aa4b41bcc34840a24054e4e2da2dd6e39ed3'>refs</a><a class='active' href='/guix/log/.gitignore'>log</a><a href='/guix/tree/.gitignore?id=0513aa4b41bcc34840a24054e4e2da2dd6e39ed3'>tree</a><a href='/guix/commit/.gitignore?id=0513aa4b41bcc34840a24054e4e2da2dd6e39ed3'>commit</a><a href='/guix/diff/.gitignore?id=0513aa4b41bcc34840a24054e4e2da2dd6e39ed3'>diff</a></td><td class='form'><form class='right' method='get' action='/guix/log/.gitignore'>
<input type='hidden' name='id' value='0513aa4b41bcc34840a24054e4e2da2dd6e39ed3'/><select name='qt'>
<option value='grep'>log msg</option>
<option value='author'>author</option>
<option value='committer'>committer</option>
<option value='range'>range</option>
</select>
<input class='txt' type='search' size='10' name='q' value=''/>
<input type='submit' value='search'/>
</form>
</td></tr></table>
<div class='path'>path: <a href='/guix/log/?id=0513aa4b41bcc34840a24054e4e2da2dd6e39ed3'>root</a>/<a href='/guix/log/.gitignore?id=0513aa4b41bcc34840a24054e4e2da2dd6e39ed3'>.gitignore</a></div><div class='content'><table class='list nowrap'><tr class='nohover'><th class='left'>Age</th><th class='left'>Commit message (<a href='/guix/log/.gitignore?id=0513aa4b41bcc34840a24054e4e2da2dd6e39ed3&amp;showmsg=1'>Expand</a>)</th><th class='left'>Author</th></tr>
<tr><td><span title='2021-10-16 01:44:34 -0400'>2021-10-16</span></td><td><a href='/guix/commit/.gitignore?id=066b1b8f781c7739f8056b81e20adf0b979614bc'>.gitignore: Ignore more autotools directories.</a><span class='msg-avail'>...</span></td><td>Sarah Morgensen</td></tr>
<tr><td><span title='2021-10-16 01:44:30 -0400'>2021-10-16</span></td><td><a href='/guix/commit/.gitignore?id=a599fcd4b09f3df3d6be66b4e64512e482697a96'>.gitignore: Ignore more temporary test directories.</a><span class='msg-avail'>...</span></td><td>Sarah Morgensen</td></tr>
<tr><td><span title='2021-09-20 14:18:21 +0000'>2021-09-20</span></td><td><a href='/guix/commit/.gitignore?id=5c4fd77097e2cecfd4780e099af7954f86779fe1'>etc: Add systemd files for running ‘guix gc’ periodically</a><span class='msg-avail'>...</span></td><td>Thiago Jung Bauermann</td></tr>
<tr><td><span title='2021-05-10 22:33:08 -0400'>2021-05-10</span></td><td><a href='/guix/commit/.gitignore?id=abff6f0fac2104c3ba2129166a4409568e9c7b16'>.gitignore: Ignore .mo files.</a><span class='msg-avail'>...</span></td><td>Maxim Cournoyer</td></tr>
<tr><td><span title='2021-05-05 16:31:05 -0400'>2021-05-05</span></td><td><a href='/guix/commit/.gitignore?id=214b77b5e749e2ca5891bfc87f946031cf8934e6'>.gitignore: Ignore .tarball-ignore.</a><span class='msg-avail'>...</span></td><td>Maxim Cournoyer</td></tr>
<tr><td><span title='2021-04-23 23:39:33 -0400'>2021-04-23</span></td><td><a href='/guix/commit/.gitignore?id=8b5339acfe381dca887b38634dcfdecae738ce7b'>.gitignore: Ignore release artifacts.</a><span class='msg-avail'>...</span></td><td>Maxim Cournoyer</td></tr>
<tr><td><span title='2021-04-23 21:32:46 -0400'>2021-04-23</span></td><td><a href='/guix/commit/.gitignore?id=129823c4997c65ad0ee711ab2fcfc91d00e6278c'>.gitignore: Ignore generated .pot files.</a><span class='msg-avail'>...</span></td><td>Maxim Cournoyer</td></tr>
<tr><td><span title='2020-10-20 19:16:21 +0200'>2020-10-20</span></td><td><a href='/guix/commit/.gitignore?id=e6994bff2ef461a2860e4207095746a5565cbf0e'>gitignore: Ignore generated guile binary and intermediate products.</a><span class='msg-avail'>...</span></td><td>Julien Lepiller</td></tr>
<tr><td><span title='2020-09-17 14:10:42 +0200'>2020-09-17</span></td><td><a href='/guix/commit/.gitignore?id=cabac732deffafc796537658a6c33c6c4aec821e'>guix-install.sh: Support OpenRC.</a><span class='msg-avail'>...</span></td><td>Morgan Smith</td></tr>
<tr><td><span title='2020-07-17 15:23:53 +0200'>2020-07-17</span></td><td><a href='/guix/commit/.gitignore?id=d6b05ba3534b030f8de976e340c19ac8a4118ff4'>gitignore: Don't ignore daemon source code.</a><span class='msg-avail'>...</span></td><td>Jakub Kądziołka</td></tr>
<tr><td><span title='2020-06-28 13:28:25 +0200'>2020-06-28</span></td><td><a href='/guix/commit/.gitignore?id=b9edefbc46da76fea6d56e08462618a398192189'>.gitignore: Ignore 'etc/committer.scm'.</a><span class='msg-avail'>...</span></td><td>Brice Waegeneire</td></tr>
<tr><td><span title='2020-05-16 15:37:41 +0200'>2020-05-16</span></td><td><a href='/guix/commit/.gitignore?id=1a1faa78b0498fbb71f1533beb4b65817c1d3f2a'>etc: Add a systemd unit to bind-mount @storedir@ read-only.</a><span class='msg-avail'>...</span></td><td>Tobias Geerinckx-Rice</td></tr>
<tr><td><span title='2020-05-14 23:05:42 -0400'>2020-05-14</span></td><td><a href='/guix/commit/.gitignore?id=cb21ae76714f1873d3b3fb40d5135f00ec104b85'>etc: indent-code.el: Use the --quick option.</a><span class='msg-avail'>...</span></td><td>Maxim Cournoyer</td></tr>
<tr><td><span title='2020-03-30 12:24:55 +0200'>2020-03-30</span></td><td><a href='/guix/commit/.gitignore?id=6e27d1088da07380872f0df9f308b674536cefc8'>.gitignore: Ignore test results in tests/services.</a><span class='msg-avail'>...</span></td><td>Marius Bakke</td></tr>
<tr><td><span title='2020-03-11 02:45:33 +0100'>2020-03-11</span></td><td><a href='/guix/commit/.gitignore?id=73fbe04107d38f4561636c74d28d7a4935cbb1ef'>Add system start-up files for guix-daemon.</a><span class='msg-avail'>...</span></td><td>Danny Milosavljevic</td></tr>
<tr><td><span title='2019-09-24 10:11:38 +0200'>2019-09-24</span></td><td><a href='/guix/commit/.gitignore?id=11da634a6e64afa2904542e2174aa2a185f9ac3a'>Merge branch 'master' into core-updates</a></td><td>Ludovic Courtès</td></tr>
<tr><td><span title='2019-09-18 11:38:14 +0200'>2019-09-18</span></td><td><a href='/guix/commit/.gitignore?id=7bc46ecc34ceb042ff890e5d306d0a2a736e891d'>doc: Add Guix Cookbook.</a><span class='msg-avail'>...</span></td><td>Ricardo Wurmus</td></tr>
<tr><td><span title='2019-06-14 22:09:38 +0200'>2019-06-14</span></td><td><a href='/guix/commit/.gitignore?id=92d00ca4661e186022732a47956a2bc0ef16be96'>build: Remove 'gnu/packages/bootstrap' and its binaries.</a><span class='msg-avail'>...</span></td><td>Ludovic Courtès</td></tr>