Fix CVE-2017-12836:

http://cve.mitre.org/cgi-bin/cvename.cgi?name=2017-12836
https://security-tracker.debian.org/tracker/CVE-2017-12836

Patch adpated from Debian (comments and changelog annotations removed):

https://anonscm.debian.org/cgit/collab-maint/cvs.git/commit/?h=stretch&id=41e077396e35efb6c879951f44c62dd8a1d0f094

From 41e077396e35efb6c879951f44c62dd8a1d0f094 Mon Sep 17 00:00:00 2001
From: mirabilos <m@mirbsd.org>
Date: Sat, 12 Aug 2017 03:17:18 +0200
Subject: Fix CVE-2017-12836 (Closes: #871810) for stretch

---
 debian/changelog |  6 ++++++
 src/rsh-client.c | 10 ++++++++--
 2 files changed, 14 insertions(+), 2 deletions(-)

diff --git a/src/rsh-client.c b/src/rsh-client.c
index fe0cfc4..1fc860d 100644
--- a/src/rsh-client.c
+++ b/src/rsh-client.c
@@ -105,6 +106,9 @@ start_rsh_server (cvsroot_t *root, struct buffer **to_server_p,
 	rsh_argv[i++] = argvport;
     }
 
+    /* Only non-option arguments from here. (CVE-2017-12836) */
+    rsh_argv[i++] = "--";
+
     rsh_argv[i++] = root->hostname;
     rsh_argv[i++] = cvs_server;
     if (readonlyfs)
@@ -189,6 +193,8 @@ start_rsh_server (cvsroot_t *root, struct buffer **to_server_p,
 		*p++ = argvport;
 	}
 
+	*p++ = "--";
+
 	*p++ = root->hostname;
 	*p++ = command;
 	*p++ = NULL;
-- 
cgit v0.12

746be30e0436773d8dcab69d8e36'>tree</a><a href='/guix/commit/gnu/tests/rsync.scm?id=776aa52d2bdc746be30e0436773d8dcab69d8e36'>commit</a><a href='/guix/diff/gnu/tests/rsync.scm?id=776aa52d2bdc746be30e0436773d8dcab69d8e36'>diff</a></td><td class='form'><form class='right' method='get' action='/guix/log/gnu/tests/rsync.scm'>
<input type='hidden' name='id' value='776aa52d2bdc746be30e0436773d8dcab69d8e36'/><select name='qt'>
<option value='grep'>log msg</option>
<option value='author'>author</option>
<option value='committer'>committer</option>
<option value='range'>range</option>
</select>
<input class='txt' type='search' size='10' name='q' value=''/>
<input type='submit' value='search'/>
</form>
</td></tr></table>
<div class='path'>path: <a href='/guix/log/?id=776aa52d2bdc746be30e0436773d8dcab69d8e36'>root</a>/<a href='/guix/log/gnu?id=776aa52d2bdc746be30e0436773d8dcab69d8e36'>gnu</a>/<a href='/guix/log/gnu/tests?id=776aa52d2bdc746be30e0436773d8dcab69d8e36'>tests</a>/<a href='/guix/log/gnu/tests/rsync.scm?id=776aa52d2bdc746be30e0436773d8dcab69d8e36'>rsync.scm</a></div><div class='content'><table class='list nowrap'><tr class='nohover'><th class='left'>Age</th><th class='left'>Commit message (<a href='/guix/log/gnu/tests/rsync.scm?id=776aa52d2bdc746be30e0436773d8dcab69d8e36&amp;showmsg=1'>Expand</a>)</th><th class='left'>Author</th></tr>
<tr><td><span title='2018-10-18 01:12:22 +0200'>2018-10-18</span></td><td><a href='/guix/commit/gnu/tests/rsync.scm?id=39d7fdce453b0ca23ecbed72048647debbaa58a6'>services: dhcp-client: Deprecate 'dhcp-client-service' procedure.</a><span class='msg-avail'>...</span></td><td>Ludovic Courtès</td></tr>
<tr><td><span title='2018-06-13 09:11:45 +0200'>2018-06-13</span></td><td><a href='/guix/commit/gnu/tests/rsync.scm?id=c24b15472baaa7ec67d48cbf296bbe5ab727b78f'>tests: Honor the return value of 'start-service'.</a><span class='msg-avail'>...</span></td><td>Clément Lassieur</td></tr>
<tr><td><span title='2017-09-23 21:07:27 +0100'>2017-09-23</span></td><td><a href='/guix/commit/gnu/tests/rsync.scm?id=9db7e9be59820190a97de22ba72e71fa25f9d168'>gnu: Add rsync service.</a><span class='msg-avail'>...</span></td><td>Oleg Pykhalov</td></tr>