From: Antonio Larrosa <larrosa@kde.org>
Date: Fri, 10 Mar 2017 15:40:02 +0100
Subject: Fix signature of multiplyCheckOverflow. It returns a bool, not an int

---
 libaudiofile/modules/MSADPCM.cpp | 2 +-
 sfcommands/sfconvert.c           | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/libaudiofile/modules/MSADPCM.cpp b/libaudiofile/modules/MSADPCM.cpp
index ef9c38c..d8c9553 100644
--- a/libaudiofile/modules/MSADPCM.cpp
+++ b/libaudiofile/modules/MSADPCM.cpp
@@ -116,7 +116,7 @@ int firstBitSet(int x)
 #define __has_builtin(x) 0
 #endif
 
-int multiplyCheckOverflow(int a, int b, int *result)
+bool multiplyCheckOverflow(int a, int b, int *result)
 {
 #if (defined __GNUC__ && __GNUC__ >= 5) || ( __clang__ && __has_builtin(__builtin_mul_overflow))
 	return __builtin_mul_overflow(a, b, result);
diff --git a/sfcommands/sfconvert.c b/sfcommands/sfconvert.c
index 970a3e4..367f7a5 100644
--- a/sfcommands/sfconvert.c
+++ b/sfcommands/sfconvert.c
@@ -60,7 +60,7 @@ int firstBitSet(int x)
 #define __has_builtin(x) 0
 #endif
 
-int multiplyCheckOverflow(int a, int b, int *result)
+bool multiplyCheckOverflow(int a, int b, int *result)
 {
 #if (defined __GNUC__ && __GNUC__ >= 5) || ( __clang__ && __has_builtin(__builtin_mul_overflow))
 	return __builtin_mul_overflow(a, b, result);
it/gnu/tests/gdm.scm?id=ae2213ed989051a680cf76582b758fd748838688'>commit</a><a href='/guix/diff/gnu/tests/gdm.scm?id=ae2213ed989051a680cf76582b758fd748838688'>diff</a></td><td class='form'><form class='right' method='get' action='/guix/log/gnu/tests/gdm.scm'>
<input type='hidden' name='id' value='ae2213ed989051a680cf76582b758fd748838688'/><select name='qt'>
<option value='grep'>log msg</option>
<option value='author'>author</option>
<option value='committer'>committer</option>
<option value='range'>range</option>
</select>
<input class='txt' type='search' size='10' name='q' value=''/>
<input type='submit' value='search'/>
</form>
</td></tr></table>
<div class='path'>path: <a href='/guix/log/?id=ae2213ed989051a680cf76582b758fd748838688'>root</a>/<a href='/guix/log/gnu?id=ae2213ed989051a680cf76582b758fd748838688'>gnu</a>/<a href='/guix/log/gnu/tests?id=ae2213ed989051a680cf76582b758fd748838688'>tests</a>/<a href='/guix/log/gnu/tests/gdm.scm?id=ae2213ed989051a680cf76582b758fd748838688'>gdm.scm</a></div><div class='content'><table class='list nowrap'><tr class='nohover'><th class='left'>Age</th><th class='left'>Commit message (<a href='/guix/log/gnu/tests/gdm.scm?id=ae2213ed989051a680cf76582b758fd748838688&amp;showmsg=1'>Expand</a>)</th><th class='left'>Author</th></tr>
<tr><td><span title='2023-07-19 10:38:15 -0400'>2023-07-19</span></td><td><a href='/guix/commit/gnu/tests/gdm.scm?id=ab2abe16debaae362ea04f32d66332423d2dba1b'>tests: gdm: Prefer OCR to delay.</a><span class='msg-avail'>...<span class='msg-tooltip'>* gnu/tests/gdm.scm (run-gdm-test): Use wait-for-screen-text instead of sleep.

Signed-off-by: Maxim Cournoyer &lt;maxim.cournoyer@gmail.com&gt;
Modified-by: Maxim Cournoyer &lt;maxim.cournoyer@gmail.com&gt;
</span></span></td><td>Bruno Victal</td></tr>
<tr><td><span title='2023-03-21 16:53:28 -0400'>2023-03-21</span></td><td><a href='/guix/commit/gnu/tests/gdm.scm?id=0c53cbcc5686ad54f41e54ca5137352a8e49323b'>tests: gdm: Remove tmpfs related tests.</a><span class='msg-avail'>...<span class='msg-tooltip'>This test never managed to reveal the problem described in [1] because
from gnu/system/vm.scm it is seen that our "/tmp" mount is filtered out and
replaced with a "/tmp" file-system that is mounted with (needed-for-boot? #t).
This last bit is crucial as the problem was caused by the user specified "/tmp"
file-system lacking this part which caused "/tmp" being mounted after
x11-socket-directory-service has run, effectively shadowing the directory.

[1]: &lt;https://issues.guix.gnu.org/57589&gt;

* gnu/tests/gdm.scm (%test-gdm-wayland-tmpfs): Delete variable.
(make-os): Remove tmpfs? argument.
(run-gdm-test): Remove tmpfs? argument. Add a small delay since
waiting for gdm.pid is not enough, causing the tests to fail sporadically.

Reviewed-by: Josselin Poiret &lt;dev@jpoiret.xyz&gt;
Signed-off-by: Maxim Cournoyer &lt;maxim.cournoyer@gmail.com&gt;
</span></span></td><td>Bruno Victal</td></tr>
<tr><td><span title='2022-12-04 23:12:36 +0100'>2022-12-04</span></td><td><a href='/guix/commit/gnu/tests/gdm.scm?id=b2a848d23d37f31496e1ff664f1dcf6abcdcc388'>tests: Add gdm tests.</a><span class='msg-avail'>...<span class='msg-tooltip'>* gnu/tests/gdm.scm: New file.
* gnu/local.mk: Register it.

Signed-off-by: Ludovic Courtès &lt;ludo@gnu.org&gt;
</span></span></td><td>Bruno Victal</td></tr>