From: Antonio Larrosa <larrosa@kde.org>
Date: Mon, 6 Mar 2017 12:51:22 +0100
Subject: Always check the number of coefficients

When building the library with NDEBUG, asserts are eliminated
so it's better to always check that the number of coefficients
is inside the array range.

This fixes the 00191-audiofile-indexoob issue in #41
---
 libaudiofile/WAVE.cpp | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/libaudiofile/WAVE.cpp b/libaudiofile/WAVE.cpp
index 9dd8511..0fc48e8 100644
--- a/libaudiofile/WAVE.cpp
+++ b/libaudiofile/WAVE.cpp
@@ -281,6 +281,12 @@ status WAVEFile::parseFormat(const Tag &id, uint32_t size)
 
 			/* numCoefficients should be at least 7. */
 			assert(numCoefficients >= 7 && numCoefficients <= 255);
+			if (numCoefficients < 7 || numCoefficients > 255)
+			{
+				_af_error(AF_BAD_HEADER,
+						"Bad number of coefficients");
+				return AF_FAIL;
+			}
 
 			m_msadpcmNumCoefficients = numCoefficients;
 
x</td><td class='sub right'></td></tr></table>
<table class='tabs'><tr><td>
<a href='/guix/about/'>about</a><a href='/guix/'>summary</a><a href='/guix/refs/?id=2cf45e9ef113b8a5d7a0e4c102b368fc15e8161c'>refs</a><a class='active' href='/guix/log/guix.scm?showmsg=1'>log</a><a href='/guix/tree/guix.scm?id=2cf45e9ef113b8a5d7a0e4c102b368fc15e8161c'>tree</a><a href='/guix/commit/guix.scm?id=2cf45e9ef113b8a5d7a0e4c102b368fc15e8161c'>commit</a><a href='/guix/diff/guix.scm?id=2cf45e9ef113b8a5d7a0e4c102b368fc15e8161c'>diff</a></td><td class='form'><form class='right' method='get' action='/guix/log/guix.scm'>
<input type='hidden' name='id' value='2cf45e9ef113b8a5d7a0e4c102b368fc15e8161c'/><input type='hidden' name='showmsg' value='1'/><select name='qt'>
<option value='grep'>log msg</option>
<option value='author'>author</option>
<option value='committer'>committer</option>
<option value='range'>range</option>
</select>
<input class='txt' type='search' size='10' name='q' value=''/>
<input type='submit' value='search'/>
</form>
</td></tr></table>
<div class='path'>path: <a href='/guix/log/?id=2cf45e9ef113b8a5d7a0e4c102b368fc15e8161c&amp;showmsg=1'>root</a>/<a href='/guix/log/guix.scm?id=2cf45e9ef113b8a5d7a0e4c102b368fc15e8161c&amp;showmsg=1'>guix.scm</a></div><div class='content'><table class='list nowrap'><tr class='nohover'><th class='left'>Age</th><th class='left'>Commit message (<a href='/guix/log/guix.scm?id=2cf45e9ef113b8a5d7a0e4c102b368fc15e8161c'>Collapse</a>)</th><th class='left'>Author</th></tr>
<tr class='logheader'><td><span title='2022-07-12 01:17:45 +0200'>2022-07-12</span></td><td class='logsubject'><a href='/guix/commit/guix.scm?id=4574ef267e543bcac97d9c400f30cb731df29181'>guix: Really export 'define-public'.</a></td><td>Ludovic Courtès</td></tr>
<tr class='nohover-highlight'><td/><td colspan='3' class='logmsg'>
This is a followup to 3858275962f1ac567b5dce2355035f9eddea0a05, which
didn't have any effect.

* guix.scm: Explicitly use (guix packages) so #:re-export-and-replace
is effective.


</td></tr>
<tr class='logheader'><td><span title='2021-09-14 11:50:58 +0200'>2021-09-14</span></td><td class='logsubject'><a href='/guix/commit/guix.scm?id=3858275962f1ac567b5dce2355035f9eddea0a05'>guix: Replace 'define-public'.</a></td><td>Ludovic Courtès</td></tr>
<tr class='nohover-highlight'><td/><td colspan='3' class='logmsg'>
This is a followup to 8531997d2a1e10d574a6e9ab70bc86ade6af4733.

* guix.scm: Use #:re-export-and-replace for 'define-public'.


</td></tr>
<tr class='logheader'><td><span title='2021-06-29 00:00:13 +0200'>2021-06-29</span></td><td class='logsubject'><a href='/guix/commit/guix.scm?id=e059adcb6001ab0353d969b24030d0c342f8830e'>(guix) no longer pulls in (guix ftp-client).</a></td><td>Ludovic Courtès</td></tr>
<tr class='nohover-highlight'><td/><td colspan='3' class='logmsg'>
That choice was made in 2014 and never made much sense.

* guix.scm (%public-modules): Remove 'ftp-client'.


</td></tr>