From: Antonio Larrosa <larrosa@kde.org>
Date: Mon, 6 Mar 2017 12:51:22 +0100
Subject: Always check the number of coefficients

When building the library with NDEBUG, asserts are eliminated
so it's better to always check that the number of coefficients
is inside the array range.

This fixes the 00191-audiofile-indexoob issue in #41
---
 libaudiofile/WAVE.cpp | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/libaudiofile/WAVE.cpp b/libaudiofile/WAVE.cpp
index 9dd8511..0fc48e8 100644
--- a/libaudiofile/WAVE.cpp
+++ b/libaudiofile/WAVE.cpp
@@ -281,6 +281,12 @@ status WAVEFile::parseFormat(const Tag &id, uint32_t size)
 
 			/* numCoefficients should be at least 7. */
 			assert(numCoefficients >= 7 && numCoefficients <= 255);
+			if (numCoefficients < 7 || numCoefficients > 255)
+			{
+				_af_error(AF_BAD_HEADER,
+						"Bad number of coefficients");
+				return AF_FAIL;
+			}
 
 			m_msadpcmNumCoefficients = numCoefficients;
 
></table>
<table class='tabs'><tr><td>
<a href='/guix/about/'>about</a><a href='/guix/'>summary</a><a href='/guix/refs/?id=da7dc8c8a7414eb23a44105f28cfd025a3b27eff'>refs</a><a class='active' href='/guix/log/gnu/tests/base.scm'>log</a><a href='/guix/tree/gnu/tests/base.scm?id=da7dc8c8a7414eb23a44105f28cfd025a3b27eff'>tree</a><a href='/guix/commit/gnu/tests/base.scm?id=da7dc8c8a7414eb23a44105f28cfd025a3b27eff'>commit</a><a href='/guix/diff/gnu/tests/base.scm?id=da7dc8c8a7414eb23a44105f28cfd025a3b27eff'>diff</a></td><td class='form'><form class='right' method='get' action='/guix/log/gnu/tests/base.scm'>
<input type='hidden' name='id' value='da7dc8c8a7414eb23a44105f28cfd025a3b27eff'/><select name='qt'>
<option value='grep'>log msg</option>
<option value='author'>author</option>
<option value='committer'>committer</option>
<option value='range'>range</option>
</select>
<input class='txt' type='search' size='10' name='q' value=''/>
<input type='submit' value='search'/>
</form>
</td></tr></table>
<div class='path'>path: <a href='/guix/log/?id=da7dc8c8a7414eb23a44105f28cfd025a3b27eff'>root</a>/<a href='/guix/log/gnu?id=da7dc8c8a7414eb23a44105f28cfd025a3b27eff'>gnu</a>/<a href='/guix/log/gnu/tests?id=da7dc8c8a7414eb23a44105f28cfd025a3b27eff'>tests</a>/<a href='/guix/log/gnu/tests/base.scm?id=da7dc8c8a7414eb23a44105f28cfd025a3b27eff'>base.scm</a></div><div class='content'><table class='list nowrap'><tr class='nohover'><th class='left'>Age</th><th class='left'>Commit message (<a href='/guix/log/gnu/tests/base.scm?id=da7dc8c8a7414eb23a44105f28cfd025a3b27eff&amp;showmsg=1'>Expand</a>)</th><th class='left'>Author</th></tr>
<tr><td><span title='2024-01-22 13:24:20 -0500'>2024-01-22</span></td><td><a href='/guix/commit/gnu/tests/base.scm?id=10a193596368443f441077525ebbddf787d91e4b'>gnu: Remove linux-libre 4.14.</a><span class='msg-avail'>...<span class='msg-tooltip'>* gnu/packages/linux.scm (linux-libre-4.14-version,
linux-libre-4.14-gnu-revision, deblob-scripts-4.14,
linux-libre-4.14-pristine-source, linux-libre-4.14-source,
linux-libre-headers-4.14, linux-libre-4.14, linux-libre-arm-generic-4.14,
linux-libre-arm-omap2plus-4.14): Remove variables.
* gnu/packages/aux-files/linux-libre/4.14-arm.conf,
gnu/packages/aux-files/linux-libre/4.14-i686.conf,
gnu/packages/aux-files/linux-libre/4.14-x86_64.conf: Delete files.
* Makefile.am (AUX_FILES): Remove aforementioned .conf files.
* gnu/tests/base.scm (%test-linux-libre-4.14): Remove variable.

Change-Id: I40393b5f46b989848d569c929f1d9c986736553e
</span></span></td><td>Wilko Meyer</td></tr>