From: Antonio Larrosa <larrosa@kde.org>
Date: Mon, 6 Mar 2017 18:59:26 +0100
Subject: Actually fail when error occurs in parseFormat

When there's an unsupported number of bits per sample or an invalid
number of samples per block, don't only print an error message using
the error handler, but actually stop parsing the file.

This fixes #35 (also reported at
https://bugzilla.opensuse.org/show_bug.cgi?id=1026983 and
https://blogs.gentoo.org/ago/2017/02/20/audiofile-heap-based-buffer-overflow-in-imadecodeblockwave-ima-cpp/
)
---
 libaudiofile/WAVE.cpp | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/libaudiofile/WAVE.cpp b/libaudiofile/WAVE.cpp
index 0fc48e8..d04b796 100644
--- a/libaudiofile/WAVE.cpp
+++ b/libaudiofile/WAVE.cpp
@@ -332,6 +332,7 @@ status WAVEFile::parseFormat(const Tag &id, uint32_t size)
 			{
 				_af_error(AF_BAD_NOT_IMPLEMENTED,
 					"IMA ADPCM compression supports only 4 bits per sample");
+				return AF_FAIL;
 			}
 
 			int bytesPerBlock = (samplesPerBlock + 14) / 8 * 4 * channelCount;
@@ -339,6 +340,7 @@ status WAVEFile::parseFormat(const Tag &id, uint32_t size)
 			{
 				_af_error(AF_BAD_CODEC_CONFIG,
 					"Invalid samples per block for IMA ADPCM compression");
+				return AF_FAIL;
 			}
 
 			track->f.sampleWidth = 16;
b63e1c9437967ab52c'>tree</a><a href='/guix/commit/gnu/packages/inkscape.scm?id=54e88d8da5ee1c0591b106b63e1c9437967ab52c'>commit</a><a href='/guix/diff/gnu/packages/inkscape.scm?id=54e88d8da5ee1c0591b106b63e1c9437967ab52c'>diff</a></td><td class='form'><form class='right' method='get' action='/guix/log/gnu/packages/inkscape.scm'>
<input type='hidden' name='id' value='54e88d8da5ee1c0591b106b63e1c9437967ab52c'/><select name='qt'>
<option value='grep'>log msg</option>
<option value='author'>author</option>
<option value='committer'>committer</option>
<option value='range'>range</option>
</select>
<input class='txt' type='search' size='10' name='q' value=''/>
<input type='submit' value='search'/>
</form>
</td></tr></table>
<div class='path'>path: <a href='/guix/log/?id=54e88d8da5ee1c0591b106b63e1c9437967ab52c'>root</a>/<a href='/guix/log/gnu?id=54e88d8da5ee1c0591b106b63e1c9437967ab52c'>gnu</a>/<a href='/guix/log/gnu/packages?id=54e88d8da5ee1c0591b106b63e1c9437967ab52c'>packages</a>/<a href='/guix/log/gnu/packages/inkscape.scm?id=54e88d8da5ee1c0591b106b63e1c9437967ab52c'>inkscape.scm</a></div><div class='content'><table class='list nowrap'><tr class='nohover'><th class='left'>Age</th><th class='left'>Commit message (<a href='/guix/log/gnu/packages/inkscape.scm?id=54e88d8da5ee1c0591b106b63e1c9437967ab52c&amp;showmsg=1'>Expand</a>)</th><th class='left'>Author</th></tr>
<tr><td><span title='2023-05-02 14:32:03 +0300'>2023-05-02</span></td><td><a href='/guix/commit/gnu/packages/inkscape.scm?id=45c6abaef5297b2bb76182eacb632739043a2cf3'>gnu: inkscape: Skip some tests on riscv64-linux.</a><span class='msg-avail'>...<span class='msg-tooltip'>* gnu/packages/inkscape.scm (inkscape)[arguments]: Use the custom
'disable-more-tests phase on riscv64-linux also.
</span></span></td><td>Efraim Flashner</td></tr>
<tr><td><span title='2023-05-01 00:30:21 +0300'>2023-05-01</span></td><td><a href='/guix/commit/gnu/packages/inkscape.scm?id=1ab846181f0d068f071962c596ac4173761f5c6e'>gnu: inkscape: Skip more tests on some architectures.</a><span class='msg-avail'>...<span class='msg-tooltip'>* gnu/packages/inkscape.scm (inkscape)[arguments]: Add a phase when
building for aarch64-linux or powerpc64le-linux to skip some more tests.
</span></span></td><td>Efraim Flashner</td></tr>
<tr><td><span title='2023-04-10 16:59:49 +0300'>2023-04-10</span></td><td><a href='/guix/commit/gnu/packages/inkscape.scm?id=ae5d3525348de562b84fc9faccf09fd6e06ab3df'>gnu: inkscape: Fixup inputs.</a><span class='msg-avail'>...<span class='msg-tooltip'>* gnu/packages/inkscape.scm (inkscape/stable)[inputs]: Replace librsvg
with librsvg-for-system.
(inkscape)[inputs]: Remove duplicate bash-minimal, librsvg.
</span></span></td><td>Efraim Flashner</td></tr>
<tr><td><span title='2023-01-30 12:39:40 +0200'>2023-01-30</span></td><td><a href='/guix/commit/gnu/packages/inkscape.scm?id=4cf1acc7f3033b50b0bf19e02c9f522d522d338c'>Merge remote-tracking branch 'origin/master' into core-updates</a><span class='msg-avail'>...<span class='msg-tooltip'> Conflicts:
	doc/guix.texi
	gnu/local.mk
	gnu/packages/admin.scm
	gnu/packages/base.scm
	gnu/packages/chromium.scm
	gnu/packages/compression.scm
	gnu/packages/databases.scm
	gnu/packages/diffoscope.scm
	gnu/packages/freedesktop.scm
	gnu/packages/gnome.scm
	gnu/packages/gnupg.scm
	gnu/packages/guile.scm
	gnu/packages/inkscape.scm
	gnu/packages/llvm.scm
	gnu/packages/openldap.scm
	gnu/packages/pciutils.scm
	gnu/packages/ruby.scm
	gnu/packages/samba.scm
	gnu/packages/sqlite.scm
	gnu/packages/statistics.scm
	gnu/packages/syndication.scm
	gnu/packages/tex.scm
	gnu/packages/tls.scm
	gnu/packages/version-control.scm
	gnu/packages/xml.scm
	guix/build-system/copy.scm
	guix/scripts/home.scm
</span></span></td><td>Efraim Flashner</td></tr>
<tr><td><span title='2023-01-27 18:16:55 +0100'>2023-01-27</span></td><td><a href='/guix/commit/gnu/packages/inkscape.scm?id=25b01ed77f2bff3d73fb9c8df1a0ce1bcab30d3c'>gnu: inkscape: Fix qrcode rendering.</a><span class='msg-avail'>...<span class='msg-tooltip'>Fixes &lt;https://issues.guix.gnu.org/57479&gt;.

* gnu/packages/inkscape.scm (inkscape)[inputs]: Add python-cssselect.

Signed-off-by: Ludovic Courtès &lt;ludo@gnu.org&gt;
</span></span></td><td>Michael Rohleder</td></tr>