From: Antonio Larrosa <larrosa@kde.org>
Date: Mon, 6 Mar 2017 18:59:26 +0100
Subject: Actually fail when error occurs in parseFormat

When there's an unsupported number of bits per sample or an invalid
number of samples per block, don't only print an error message using
the error handler, but actually stop parsing the file.

This fixes #35 (also reported at
https://bugzilla.opensuse.org/show_bug.cgi?id=1026983 and
https://blogs.gentoo.org/ago/2017/02/20/audiofile-heap-based-buffer-overflow-in-imadecodeblockwave-ima-cpp/
)
---
 libaudiofile/WAVE.cpp | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/libaudiofile/WAVE.cpp b/libaudiofile/WAVE.cpp
index 0fc48e8..d04b796 100644
--- a/libaudiofile/WAVE.cpp
+++ b/libaudiofile/WAVE.cpp
@@ -332,6 +332,7 @@ status WAVEFile::parseFormat(const Tag &id, uint32_t size)
 			{
 				_af_error(AF_BAD_NOT_IMPLEMENTED,
 					"IMA ADPCM compression supports only 4 bits per sample");
+				return AF_FAIL;
 			}
 
 			int bytesPerBlock = (samplesPerBlock + 14) / 8 * 4 * channelCount;
@@ -339,6 +340,7 @@ status WAVEFile::parseFormat(const Tag &id, uint32_t size)
 			{
 				_af_error(AF_BAD_CODEC_CONFIG,
 					"Invalid samples per block for IMA ADPCM compression");
+				return AF_FAIL;
 			}
 
 			track->f.sampleWidth = 16;
936d3186df4513'>tree</a><a href='/guix/commit/etc/snippets/scheme-mode?id=33ae2fb39824fbcdbd8f39a7a2936d3186df4513'>commit</a><a href='/guix/diff/etc/snippets/scheme-mode?id=33ae2fb39824fbcdbd8f39a7a2936d3186df4513'>diff</a></td><td class='form'><form class='right' method='get' action='/guix/log/etc/snippets/scheme-mode'>
<input type='hidden' name='id' value='33ae2fb39824fbcdbd8f39a7a2936d3186df4513'/><select name='qt'>
<option value='grep'>log msg</option>
<option value='author'>author</option>
<option value='committer'>committer</option>
<option value='range'>range</option>
</select>
<input class='txt' type='search' size='10' name='q' value=''/>
<input type='submit' value='search'/>
</form>
</td></tr></table>
<div class='path'>path: <a href='/guix/log/?id=33ae2fb39824fbcdbd8f39a7a2936d3186df4513'>root</a>/<a href='/guix/log/etc?id=33ae2fb39824fbcdbd8f39a7a2936d3186df4513'>etc</a>/<a href='/guix/log/etc/snippets?id=33ae2fb39824fbcdbd8f39a7a2936d3186df4513'>snippets</a>/<a href='/guix/log/etc/snippets/scheme-mode?id=33ae2fb39824fbcdbd8f39a7a2936d3186df4513'>scheme-mode</a></div><div class='content'><table class='list nowrap'><tr class='nohover'><th class='left'>Age</th><th class='left'>Commit message (<a href='/guix/log/etc/snippets/scheme-mode?id=33ae2fb39824fbcdbd8f39a7a2936d3186df4513&amp;showmsg=1'>Expand</a>)</th><th class='left'>Author</th></tr>
<tr><td><span title='2021-06-26 22:45:28 +0200'>2021-06-26</span></td><td><a href='/guix/commit/etc/snippets/scheme-mode?id=d822c592438d025107c95dc49435a4c9c3cfd863'>etc: snippets: Use ‘hg-file-name’ when origin uses ‘hg-fetch’</a><span class='msg-avail'>...<span class='msg-tooltip'>Adjust to changes in commit aaafd19bd1e37265de07e246286a6819792c25b4.

* etc/snippets/scheme-mode/guix-origin: Use ‘hg-file-name’ instead of
‘string-append’ when ‘method’ for origin is ‘hg-fetch’.

Signed-off-by: Ludovic Courtès &lt;ludo@gnu.org&gt;
</span></span></td><td>Xinglu Chen</td></tr>
<tr><td><span title='2020-12-23 17:30:14 +0100'>2020-12-23</span></td><td><a href='/guix/commit/etc/snippets/scheme-mode?id=d6b0d219c6e4e8392fbeb3263c95e9b7d7c75e1c'>etc: snippets: Add new build systems to package snippet.</a><span class='msg-avail'>...<span class='msg-tooltip'>* etc/snippets/scheme-mode/guix-package: Add the following as possibilities
for the build-system field:

clojure-build-system
copy-build-system
dune-build-system
guile-build-system
julia-build-system
linux-module-build-system
maven-build-system
node-build-system
qt-build-system
rakudo-build-system

Signed-off-by: Ludovic Courtès &lt;ludo@gnu.org&gt;
</span></span></td><td>Morgan Smith</td></tr>