From fde6d79fb8363c4a329a184ef0b107156602b225 Mon Sep 17 00:00:00 2001
From: Wim Taymans <wtaymans@redhat.com>
Date: Thu, 27 Sep 2018 10:48:45 +0200
Subject: [PATCH] ModuleState: handle compress/decompress init failure

When the unit initcompress or initdecompress function fails,
m_fileModule is NULL. Return AF_FAIL in that case instead of
causing NULL pointer dereferences later.

Fixes #49
---
 libaudiofile/modules/ModuleState.cpp | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/libaudiofile/modules/ModuleState.cpp b/libaudiofile/modules/ModuleState.cpp
index 0c29d7a..070fd9b 100644
--- a/libaudiofile/modules/ModuleState.cpp
+++ b/libaudiofile/modules/ModuleState.cpp
@@ -75,6 +75,9 @@ status ModuleState::initFileModule(AFfilehandle file, Track *track)
 		m_fileModule = unit->initcompress(track, file->m_fh, file->m_seekok,
 			file->m_fileFormat == AF_FILE_RAWDATA, &chunkFrames);
 
+	if (!m_fileModule)
+		return AF_FAIL;
+
 	if (unit->needsRebuffer)
 	{
 		assert(unit->nativeSampleFormat == AF_SAMPFMT_TWOSCOMP);
href='/guix/about/'>about</a><a href='/guix/'>summary</a><a href='/guix/refs/?id=3b9892ad07a943ff17f72377f6ca344041237979'>refs</a><a class='active' href='/guix/log/etc/disarchive-manifest.scm'>log</a><a href='/guix/tree/etc/disarchive-manifest.scm?id=3b9892ad07a943ff17f72377f6ca344041237979'>tree</a><a href='/guix/commit/etc/disarchive-manifest.scm?id=3b9892ad07a943ff17f72377f6ca344041237979'>commit</a><a href='/guix/diff/etc/disarchive-manifest.scm?id=3b9892ad07a943ff17f72377f6ca344041237979'>diff</a></td><td class='form'><form class='right' method='get' action='/guix/log/etc/disarchive-manifest.scm'>
<input type='hidden' name='id' value='3b9892ad07a943ff17f72377f6ca344041237979'/><select name='qt'>
<option value='grep'>log msg</option>
<option value='author'>author</option>
<option value='committer'>committer</option>
<option value='range'>range</option>
</select>
<input class='txt' type='search' size='10' name='q' value=''/>
<input type='submit' value='search'/>
</form>
</td></tr></table>
<div class='path'>path: <a href='/guix/log/?id=3b9892ad07a943ff17f72377f6ca344041237979'>root</a>/<a href='/guix/log/etc?id=3b9892ad07a943ff17f72377f6ca344041237979'>etc</a>/<a href='/guix/log/etc/disarchive-manifest.scm?id=3b9892ad07a943ff17f72377f6ca344041237979'>disarchive-manifest.scm</a></div><div class='content'><table class='list nowrap'><tr class='nohover'><th class='left'>Age</th><th class='left'>Commit message (<a href='/guix/log/etc/disarchive-manifest.scm?id=3b9892ad07a943ff17f72377f6ca344041237979&amp;showmsg=1'>Expand</a>)</th><th class='left'>Author</th></tr>
<tr><td><span title='2022-08-06 23:14:41 +0200'>2022-08-06</span></td><td><a href='/guix/commit/etc/disarchive-manifest.scm?id=eab5366e679c149cf0a5abeb9a196700b171d9da'>disarchive-manifest: Exclude the Chromium tarball.</a><span class='msg-avail'>...<span class='msg-tooltip'>* etc/disarchive-manifest.scm (disarchive-collection): Exclude
"chromium-" tarballs.
</span></span></td><td>Ludovic Courtès</td></tr>
<tr><td><span title='2022-08-05 15:28:02 +0200'>2022-08-05</span></td><td><a href='/guix/commit/etc/disarchive-manifest.scm?id=6d4a0ccecb58c62a95f7f36fa2f4fa53dd52312e'>disarchive-manifest: Filter out origins without a hash.</a><span class='msg-avail'>...<span class='msg-tooltip'>* etc/disarchive-manifest.scm (disarchive-collection): Filter out
origins with a phony hash.
</span></span></td><td>Ludovic Courtès</td></tr>
<tr><td><span title='2022-08-05 00:14:29 +0200'>2022-08-05</span></td><td><a href='/guix/commit/etc/disarchive-manifest.scm?id=2acffd56a58c01785ea6ea738b79991c0685d364'>disarchive-manifest: Handle tar.xz archives.</a><span class='msg-avail'>...<span class='msg-tooltip'>* etc/disarchive-manifest.scm (tarball-origin?): Add ".tar.xz".
</span></span></td><td>Ludovic Courtès</td></tr>