From fde6d79fb8363c4a329a184ef0b107156602b225 Mon Sep 17 00:00:00 2001
From: Wim Taymans <wtaymans@redhat.com>
Date: Thu, 27 Sep 2018 10:48:45 +0200
Subject: [PATCH] ModuleState: handle compress/decompress init failure

When the unit initcompress or initdecompress function fails,
m_fileModule is NULL. Return AF_FAIL in that case instead of
causing NULL pointer dereferences later.

Fixes #49
---
 libaudiofile/modules/ModuleState.cpp | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/libaudiofile/modules/ModuleState.cpp b/libaudiofile/modules/ModuleState.cpp
index 0c29d7a..070fd9b 100644
--- a/libaudiofile/modules/ModuleState.cpp
+++ b/libaudiofile/modules/ModuleState.cpp
@@ -75,6 +75,9 @@ status ModuleState::initFileModule(AFfilehandle file, Track *track)
 		m_fileModule = unit->initcompress(track, file->m_fh, file->m_seekok,
 			file->m_fileFormat == AF_FILE_RAWDATA, &chunkFrames);
 
+	if (!m_fileModule)
+		return AF_FAIL;
+
 	if (unit->needsRebuffer)
 	{
 		assert(unit->nativeSampleFormat == AF_SAMPFMT_TWOSCOMP);
about/'>about</a><a href='/guix/'>summary</a><a href='/guix/refs/?id=65bf9f6b2d88dfb91f56a5cc3eefc273647d7a91'>refs</a><a class='active' href='/guix/log/gnu/services/cups.scm'>log</a><a href='/guix/tree/gnu/services/cups.scm?id=65bf9f6b2d88dfb91f56a5cc3eefc273647d7a91'>tree</a><a href='/guix/commit/gnu/services/cups.scm?id=65bf9f6b2d88dfb91f56a5cc3eefc273647d7a91'>commit</a><a href='/guix/diff/gnu/services/cups.scm?id=65bf9f6b2d88dfb91f56a5cc3eefc273647d7a91'>diff</a></td><td class='form'><form class='right' method='get' action='/guix/log/gnu/services/cups.scm'>
<input type='hidden' name='id' value='65bf9f6b2d88dfb91f56a5cc3eefc273647d7a91'/><select name='qt'>
<option value='grep'>log msg</option>
<option value='author'>author</option>
<option value='committer'>committer</option>
<option value='range'>range</option>
</select>
<input class='txt' type='search' size='10' name='q' value=''/>
<input type='submit' value='search'/>
</form>
</td></tr></table>
<div class='path'>path: <a href='/guix/log/?id=65bf9f6b2d88dfb91f56a5cc3eefc273647d7a91'>root</a>/<a href='/guix/log/gnu?id=65bf9f6b2d88dfb91f56a5cc3eefc273647d7a91'>gnu</a>/<a href='/guix/log/gnu/services?id=65bf9f6b2d88dfb91f56a5cc3eefc273647d7a91'>services</a>/<a href='/guix/log/gnu/services/cups.scm?id=65bf9f6b2d88dfb91f56a5cc3eefc273647d7a91'>cups.scm</a></div><div class='content'><table class='list nowrap'><tr class='nohover'><th class='left'>Age</th><th class='left'>Commit message (<a href='/guix/log/gnu/services/cups.scm?id=65bf9f6b2d88dfb91f56a5cc3eefc273647d7a91&amp;showmsg=1'>Expand</a>)</th><th class='left'>Author</th></tr>
<tr><td><span title='2020-11-21 23:00:06 +0100'>2020-11-21</span></td><td><a href='/guix/commit/gnu/services/cups.scm?id=13180f6accf815253107420d264e0c82ad064608'>services: cups: Add Splix by default.</a><span class='msg-avail'>...</span></td><td>Tobias Geerinckx-Rice</td></tr>
<tr><td><span title='2020-11-21 22:59:47 +0100'>2020-11-21</span></td><td><a href='/guix/commit/gnu/services/cups.scm?id=0b57c1b09efb74f0b30fd74c7c1eb2da1f5957bc'>gnu: Rename escpr to epson-inkjet-printer-escpr.</a><span class='msg-avail'>...</span></td><td>Tobias Geerinckx-Rice</td></tr>
<tr><td><span title='2020-11-18 10:00:11 +0100'>2020-11-18</span></td><td><a href='/guix/commit/gnu/services/cups.scm?id=8490fa0253fa8ee5613a89851273e007494ea79b'>services: cups: Add some extensions by default.</a><span class='msg-avail'>...</span></td><td>Danny Milosavljevic</td></tr>
<tr><td><span title='2020-05-26 16:03:56 +0200'>2020-05-26</span></td><td><a href='/guix/commit/gnu/services/cups.scm?id=6ac7526e488ad3dd73080d1c00efe2066b1bf0a2'>services: Fix permissions of directory /var/spool/cups/tmp.</a><span class='msg-avail'>...</span></td><td>Danny Milosavljevic</td></tr>
<tr><td><span title='2019-08-31 03:24:41 +0200'>2019-08-31</span></td><td><a href='/guix/commit/gnu/services/cups.scm?id=5a097cdd5446587511dbee049ad706366c74e5ad'>services: cups: Rename ‘retry-this-job’ to ‘retry-current-job’.</a><span class='msg-avail'>...</span></td><td>Tobias Geerinckx-Rice</td></tr>
<tr><td><span title='2019-08-30 03:41:42 +0200'>2019-08-30</span></td><td><a href='/guix/commit/gnu/services/cups.scm?id=70186c24eee7603e1763143ba97ab6abea63f10c'>services: cups: Move SET-ENV to FILES-CONFIGURATION.</a><span class='msg-avail'>...</span></td><td>Tobias Geerinckx-Rice</td></tr>
<tr><td><span title='2019-08-30 03:41:42 +0200'>2019-08-30</span></td><td><a href='/guix/commit/gnu/services/cups.scm?id=ee0de9945438cce41ef20e37144f41a8d40cd1ab'>services: cups: Add BrowseDNSSDSubTypes directive.</a><span class='msg-avail'>...</span></td><td>Tobias Geerinckx-Rice</td></tr>
<tr><td><span title='2019-08-27 08:58:37 +0200'>2019-08-27</span></td><td><a href='/guix/commit/gnu/services/cups.scm?id=9e3ef6f3e37aa65f25cbe025106324144ed42b3d'>services: cups: Update SSL-OPTIONS docstring.</a><span class='msg-avail'>...</span></td><td>Tobias Geerinckx-Rice</td></tr>
<tr><td><span title='2019-08-27 08:49:14 +0200'>2019-08-27</span></td><td><a href='/guix/commit/gnu/services/cups.scm?id=f9c1ebdb7daea30ceaf73f43bf15c222dc4a58ad'>services: cups: Complete SSL-OPTIONS.</a><span class='msg-avail'>...</span></td><td>Tobias Geerinckx-Rice</td></tr>
<tr><td><span title='2019-06-05 17:27:23 +0200'>2019-06-05</span></td><td><a href='/guix/commit/gnu/services/cups.scm?id=36273ebde20db42d864e315c954d84d2b4957070'>services: cups: Create /var/cache on activation.</a><span class='msg-avail'>...</span></td><td>Alex Griffin</td></tr>
<tr><td><span title='2019-03-13 23:12:43 +0100'>2019-03-13</span></td><td><a href='/guix/commit/gnu/services/cups.scm?id=59e80445882f8b0379e54916f89510c0deda6698'>Remove traces of "GuixSD".</a><span class='msg-avail'>...</span></td><td>Ludovic Courtès</td></tr>