From fde6d79fb8363c4a329a184ef0b107156602b225 Mon Sep 17 00:00:00 2001
From: Wim Taymans <wtaymans@redhat.com>
Date: Thu, 27 Sep 2018 10:48:45 +0200
Subject: [PATCH] ModuleState: handle compress/decompress init failure

When the unit initcompress or initdecompress function fails,
m_fileModule is NULL. Return AF_FAIL in that case instead of
causing NULL pointer dereferences later.

Fixes #49
---
 libaudiofile/modules/ModuleState.cpp | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/libaudiofile/modules/ModuleState.cpp b/libaudiofile/modules/ModuleState.cpp
index 0c29d7a..070fd9b 100644
--- a/libaudiofile/modules/ModuleState.cpp
+++ b/libaudiofile/modules/ModuleState.cpp
@@ -75,6 +75,9 @@ status ModuleState::initFileModule(AFfilehandle file, Track *track)
 		m_fileModule = unit->initcompress(track, file->m_fh, file->m_seekok,
 			file->m_fileFormat == AF_FILE_RAWDATA, &chunkFrames);
 
+	if (!m_fileModule)
+		return AF_FAIL;
+
 	if (unit->needsRebuffer)
 	{
 		assert(unit->nativeSampleFormat == AF_SAMPFMT_TWOSCOMP);
'sub right'></td></tr></table>
<table class='tabs'><tr><td>
<a href='/guix/about/'>about</a><a href='/guix/'>summary</a><a href='/guix/refs/?id=2ac8e95dbafc21b415af4aab6db591f4eba4b941'>refs</a><a class='active' href='/guix/log/nix/libstore/optimise-store.cc?showmsg=1'>log</a><a href='/guix/tree/nix/libstore/optimise-store.cc?id=2ac8e95dbafc21b415af4aab6db591f4eba4b941'>tree</a><a href='/guix/commit/nix/libstore/optimise-store.cc?id=2ac8e95dbafc21b415af4aab6db591f4eba4b941'>commit</a><a href='/guix/diff/nix/libstore/optimise-store.cc?id=2ac8e95dbafc21b415af4aab6db591f4eba4b941'>diff</a></td><td class='form'><form class='right' method='get' action='/guix/log/nix/libstore/optimise-store.cc'>
<input type='hidden' name='id' value='2ac8e95dbafc21b415af4aab6db591f4eba4b941'/><input type='hidden' name='showmsg' value='1'/><select name='qt'>
<option value='grep'>log msg</option>
<option value='author'>author</option>
<option value='committer'>committer</option>
<option value='range'>range</option>
</select>
<input class='txt' type='search' size='10' name='q' value=''/>
<input type='submit' value='search'/>
</form>
</td></tr></table>
<div class='path'>path: <a href='/guix/log/?id=2ac8e95dbafc21b415af4aab6db591f4eba4b941&amp;showmsg=1'>root</a>/<a href='/guix/log/nix?id=2ac8e95dbafc21b415af4aab6db591f4eba4b941&amp;showmsg=1'>nix</a>/<a href='/guix/log/nix/libstore?id=2ac8e95dbafc21b415af4aab6db591f4eba4b941&amp;showmsg=1'>libstore</a>/<a href='/guix/log/nix/libstore/optimise-store.cc?id=2ac8e95dbafc21b415af4aab6db591f4eba4b941&amp;showmsg=1'>optimise-store.cc</a></div><div class='content'><table class='list nowrap'><tr class='nohover'><th class='left'>Age</th><th class='left'>Commit message (<a href='/guix/log/nix/libstore/optimise-store.cc?id=2ac8e95dbafc21b415af4aab6db591f4eba4b941'>Collapse</a>)</th><th class='left'>Author</th></tr>
<tr class='logheader'><td><span title='2021-11-16 14:34:28 +0100'>2021-11-16</span></td><td class='logsubject'><a href='/guix/commit/nix/libstore/optimise-store.cc?id=472a0e82a52a3d5d841e1dfad6b13e26082a5750'>daemon: Do not deduplicate files smaller than 8 KiB.</a></td><td>Ludovic Courtès</td></tr>
<tr class='nohover-highlight'><td/><td colspan='3' class='logmsg'>
Files smaller than 8 KiB typically represent ~70% of the entries in
/gnu/store/.links but only contribute to ~4% of the space savings
afforded by deduplication.

Not considering these files for deduplication speeds up file insertion
in the store and, more importantly, leaves 'removeUnusedLinks' with
fewer entries to traverse, thereby speeding it up proportionally.

Partly fixes &lt;https://issues.guix.gnu.org/24937&gt;.

* config-daemon.ac: Remove symlink hard link check and CAN_LINK_SYMLINK
definition.
* guix/store/deduplication.scm (%deduplication-minimum-size): New
variable.
(deduplicate)[loop]: Do not recurse when FILE's size is below
%DEDUPLICATION-MINIMUM-SIZE.
(dump-port): New procedure.
(dump-file/deduplicate)[hash]: Turn into...
[dump-and-compute-hash]: ... this thunk.
Call 'deduplicate' only when SIZE is greater than
%DEDUPLICATION-MINIMUM-SIZE; otherwise call 'dump-port'.
* nix/libstore/gc.cc (LocalStore::removeUnusedLinks): Drop files where
st.st_size &lt; deduplicationMinSize.
* nix/libstore/local-store.hh (deduplicationMinSize): New declaration.
* nix/libstore/optimise-store.cc (deduplicationMinSize): New variable.
(LocalStore::optimisePath_): Return when PATH is a symlink or smaller
than 'deduplicationMinSize'.
* tests/derivations.scm ("identical files are deduplicated"): Produce
files bigger than %DEDUPLICATION-MINIMUM-SIZE.
* tests/nar.scm ("restore-file-set with directories (signed, valid)"):
Likewise.
* tests/store-deduplication.scm ("deduplicate, below %deduplication-minimum-size"):
New test.
("deduplicate", "deduplicate, ENOSPC"): Produce files bigger than
%DEDUPLICATION-MINIMUM-SIZE.
* tests/store.scm ("substitute, deduplication"): Likewise.


</td></tr>
<tr class='logheader'><td><span title='2020-06-25 12:29:22 +0200'>2020-06-25</span></td><td class='logsubject'><a href='/guix/commit/nix/libstore/optimise-store.cc?id=b930f0ba2115f71c323d4bf3d72efb763f716296'>daemon: Correctly handle EMLINK corner case when deduplicating.</a></td><td>Ludovic Courtès</td></tr>
<tr class='nohover-highlight'><td/><td colspan='3' class='logmsg'>
Suggested by Caleb Ristvedt &lt;caleb.ristvedt@cune.org&gt;.

* nix/libstore/optimise-store.cc (LocalStore::optimisePath_): Save errno
from 'rename' before calling 'unlink'.


</td></tr>