From e2b1bab19a782cb62bb010d1c2925ab7314fb113 Mon Sep 17 00:00:00 2001 diff --git a/absl/base/internal/strerror.cc b/absl/base/internal/strerror.cc index d66ba120..0d6226fd 100644 --- a/absl/base/internal/strerror.cc +++ b/absl/base/internal/strerror.cc @@ -51,7 +51,6 @@ const char* StrErrorAdaptor(int errnum, char* buf, size_t buflen) { } std::string StrErrorInternal(int errnum) { - absl::base_internal::ErrnoSaver errno_saver; char buf[100]; const char* str = StrErrorAdaptor(errnum, buf, sizeof buf); if (*str == '\0') { @@ -76,6 +75,7 @@ std::array* NewStrErrorTable() { } // namespace std::string StrError(int errnum) { + absl::base_internal::ErrnoSaver errno_saver; static const auto* table = NewStrErrorTable(); if (errnum >= 0 && errnum < static_cast(table->size())) { return (*table)[errnum]; diff --git a/absl/base/internal/strerror_test.cc b/absl/base/internal/strerror_test.cc index a53da97f..e32d5b5c 100644 --- a/absl/base/internal/strerror_test.cc +++ b/absl/base/internal/strerror_test.cc @@ -62,12 +62,14 @@ TEST(StrErrorTest, MultipleThreads) { ++counter; errno = ERANGE; const std::string value = absl::base_internal::StrError(i); + // EXPECT_* could change errno. Stash it first. + int check_err = errno; + EXPECT_THAT(check_err, Eq(ERANGE)); // Only the GNU implementation is guaranteed to provide the // string "Unknown error nnn". POSIX doesn't say anything. if (!absl::StartsWith(value, "Unknown error ")) { - EXPECT_THAT(absl::base_internal::StrError(i), Eq(expected_strings[i])); + EXPECT_THAT(value, Eq(expected_strings[i])); } - EXPECT_THAT(errno, Eq(ERANGE)); } }; ange
AgeCommit message (Expand)Author
2024-08-05Change email of Evgeny Pisemsky....* .mailmap: Add entry to Evgeny Pisemsky. * gnu/packages/emacs-xyz.scm, gnu/packages/engineering.scm, gnu/packages/guile-xyz.scm, gnu/packages/hardware.scm, gnu/packages/perl.scm, gnu/packages/python-xyz.scm, gnu/packages/sdl.scm, gnu/packages/web.scm: Adjust copyright line. Change-Id: I9a10be1ee7cc164f18d826b51348ee26eee2ca4b Signed-off-by: Efraim Flashner <efraim@flashner.co.il> Evgeny Pisemsky
2024-01-07Update mailmap....* .mailmap: Add entry for Tomas Volf. Change-Id: I0a8b43b3b7f71c3020f96118adcbad8937a290fb Signed-off-by: Mathieu Othacehe <othacehe@gnu.org> Tomas Volf
2023-08-16Update email addresses for Juliana Sims....* .mailmap: Add an entry for Juliana. * gnu/packages/admin.scm, gnu/packages/audio.scm, gnu/packages/build-tools.scm, gnu/packages/scheme.scm: Update Juliana's email. Signed-off-by: Ludovic Courtès <ludo@gnu.org> Juliana Sims
2022-01-11Update mailmap....* .mailmap: Add entry for Zheng Junjie. Leo Famulari
2021-11-06Update mailmap and copyright assignments for Liliana Marie Prikler....Use full names everywhere. * .mailmap: Use full name for Liliana Marie Prikler. * gnu/packages/zig.scm: Likewise. Liliana Marie Prikler
2021-09-06Update mailmap....* .mailmap: Add entry for Liliana Marie Prikler. Liliana Marie Prikler
2021-09-04Update mailmap....* .mailmap: Alias all my contributions to the same identity. Marius Bakke
2021-07-27Update mailmap....* .mailmap: Add entry for Christine Lemmer-Webber. Leo Famulari
2021-07-08mailmap: Update entries for Matthew James Kraai....* .mailmap: Change name for Matthew James Kraai. * gnu/packages/lisp-xyz.scm, gnu/packages/python-xyz.scm, gnu/packages/rust.scm: Likewise. Signed-off-by: Nicolas Goaziou <mail@nicolasgoaziou.fr> Matthew James Kraai
2021-06-23gnu: Add Sollya....* gnu/packages/algebra.scm (sollya): New variable. * .mailmap: Adjust "proper email" for `git commit`. Eric Bavier
2021-04-21Update email address for Kei....* .mailmap: Remove obsolete email for Kei. Kei Kebreau