Age | Commit message (Expand) | Author |
2022-12-18 | installer: final: Delete SQLite WAL and shm files upon completion....Previously, db.sqlite-{wal,shm} could be left behind after stopping
guix-daemon. When resuming installation, SQLite could end up behaving
as if transactions visible in the WAL file had been committed, in spite
of having restored SAVED-DATABASE.
Fixes <https://issues.guix.gnu.org/59784>.
Reported by pelzflorian (Florian Pelz) <pelzflorian@pelzflorian.de>.
* gnu/installer/final.scm (install-system): Before restarting
guix-daemon, delete db.sqlite-{wal,shm}.
| Ludovic Courtès |
2022-12-18 | installer: final: Stop guix-daemon before accessing store database....As part of fixing <https://issues.guix.gnu.org/59784>, make sure
/var/guix/db.sqlite is only copied while guix-daemon is stopped.
* gnu/installer/final.scm (call-with-mnt-container): Add FIXME comment.
(install-system): Copy DATABASE-FILE and SAVED-DATABASE only when
'guix-daemon' is stopped. Add logging lines.
| Ludovic Courtès |
2022-10-20 | installer: Run the "guix system init" command in a PTY....Fixes: <https://issues.guix.gnu.org/55360>
* gnu/installer/utils.scm (run-external-command-with-handler/tty): New
procedure.
(run-external-command-with-line-hooks, run-command): Add a TTY? argument.
* gnu/installer/final.scm (install-system): Call run-command with TTY?
argument set to #true.
| Mathieu Othacehe |
2022-02-02 | installer: Use system-wide guix for system init....* gnu/installer.scm (installer-program): Remove dependency on the guix
package for the PATH.
* gnu/installer/final.scm (install-system): Set PATH inside container
to /run/current-system/profile/bin/.
Signed-off-by: Mathieu Othacehe <othacehe@gnu.org>
| Josselin Poiret |
2022-02-02 | installer: Turn passwords into opaque records....* gnu/installer/user.scm (<secret>, secret?, make-secret,
secret-content): Add opaque <secret> record that boxes its contents,
with a custom printer that doesn't display anything.
* gnu/installer/newt/user.scm (run-user-add-page, run-user-page): Box
it.
* gnu/installer/final.scm (create-user-database): Unbox it.
Signed-off-by: Mathieu Othacehe <othacehe@gnu.org>
| Josselin Poiret |
2022-02-02 | installer: Remove specific logging code....* gnu/installer/final.scm (install-system): Remove command logging to
syslog, as this is taken care of by the new facilities.
Signed-off-by: Mathieu Othacehe <othacehe@gnu.org>
| Josselin Poiret |
2022-02-02 | installer: Keep PATH inside the install container....* gnu/installer/final.scm (install-system): Set PATH inside the
container.
Signed-off-by: Mathieu Othacehe <othacehe@gnu.org>
| Josselin Poiret |
2022-02-02 | installer: Use new installer-log-line everywhere....* gnu/installer.scm (installer-program)
* gnu/installer/final.scm (install-locale)
* gnu/installer/newt.scm (init)
* gnu/installer/newt/final.scm (run-final-page)
* gnu/installer/newt/page.scm (run-form-with-clients)
* gnu/installer/newt/partition.scm (run-partitioning-page)
* gnu/installer/parted.scm (eligible-devices, mkpart,
luks-format-and-open, luks-close, mount-user-partitions,
umount-user-partitions, free-parted):
* gnu/installer/steps.scm (run-installer-steps):
* gnu/installer/utils.scm (run-command, send-to-clients): Use it.
Signed-off-by: Mathieu Othacehe <othacehe@gnu.org>
| Josselin Poiret |
2022-01-14 | installer: Install the locale before mounting the cow-store....Fixes: <https://issues.guix.gnu.org/52831>.
Make sure to install the en_US.utf8 fallback locale if the selected locale is
not supported.
* gnu/installer/final.scm (install-locale): New procedure.
(install-system): Call it.
| Mathieu Othacehe |
2022-01-14 | installer: Do not set the locale in run-command....Installing the locale inside the container, once the cow-store is mounted,
causes the process to keep opened locale files that can later prevent the
cow-store umount.
* gnu/installer/utils.scm (run-command): Remove locale argument.
* gnu/installer/final.scm (install-system): Adapt it.
| Mathieu Othacehe |
2022-01-14 | installer: Remove an unused procedure....* gnu/installer/final.scm (kill-cow-users): Remove it.
| Mathieu Othacehe |
2020-09-10 | installer: final: Introduce call-with-mnt-container....* gnu/installer/final.scm (call-with-mnt-container): New procedure,
(install-system): use it instead of call-with-container, to make sure that the
container is not jailed.
| Mathieu Othacehe |
2020-09-02 | installer: Run the installation inside a container....When the store overlay is mounted, other processes such as kmscon, udev
and guix-daemon may open files from the store, preventing the
underlying install support from being umounted. See:
https://lists.gnu.org/archive/html/guix-devel/2018-12/msg00161.html.
To avoid this situation, mount the store overlay inside a container,
and run the installation from within that container.
* gnu/build/shepherd.scm (fork+exec-command/container): New procedure.
* gnu/services/base.scm (guix-shepherd-service): Support an optional PID
argument passed to the "start" method. If that argument is passed, ensure that
guix-daemon enters the given PID MNT namespace by using
fork+exec-command/container procedure.
* gnu/installer/final.scm (umount-cow-store): Remove it,
(install-system): run the installation from within a container.
* gnu/installer/newt/final.scm (run-install-shell): Remove the display hack.
| Mathieu Othacehe |
2020-06-16 | installer: final: Remove restart-service procedure....* gnu/installer/final.scm (umount-cow-store): Remove "restart-service" that is
now provided by (gnu services herd).
| Mathieu Othacehe |
2020-06-13 | install: final: Add some logging....* gnu/installer/final.scm (umount-cow-store): Add some logging.
| Mathieu Othacehe |
2020-06-09 | installer: final: Dump "guix system init" command output when testing....When debugging the installation tests, it can be very handy to be able to read
"guix system init" command output.
* gnu/installer/final.scm (install-system): Dump installation command output
to the console when running the installation tests.
| Mathieu Othacehe |
2020-06-09 | installer: final: Remove left-over pk call....* gnu/installer/final.scm (kill-cow-users): Remove pk call.
| Mathieu Othacehe |
2020-06-05 | installer: final: Add some extra logging....* gnu/installer/final.scm (kill-cow-users): Log the killed process name,
(umount-cow-store): inform that we are umounting the cow-store.
| Mathieu Othacehe |
2020-03-23 | installer: Fix cow-store umount issue....* gnu/installer/final.scm (kill-cow-users): Ignore exception that could be
raised if a process disappears between reading its pid and its maps file.
| Mathieu Othacehe |
2020-03-05 | installer: Fix cow-store umount....This fixes <https://bugs.gnu.org/39712>.
The guix-daemon was preventing the cow-store umount, so restart it. Some
udevd workers, using cow-store files might also still be around, so have some
umount retries.
* gnu/installer/final.scm (kill-cow-users): New procedure,
(umount-cow-store): restart guix-daemon and kill all processes started from
within the cow-store before trying to umount the store overlay. Also try 5
times to umount the overlay in case it is still busy.
| Mathieu Othacehe |
2020-03-05 | installer: Honor /tmp/installer-system-init-options....* gnu/installer/final.scm (install-system): Honor
"/tmp/installer-system-init-options".
| Ludovic Courtès |
2020-03-05 | installer: Run commands without hopping through the shell....* gnu/installer/utils.scm (run-shell-command): Rename to...
(run-command): Remove call to 'call-with-temporary-output-file' and hop
through Bash. Expect COMMAND to be a list of strings rather than a
string.
* gnu/installer/final.scm (install-system): Turn INSTALL-COMMAND into a
list of strings and pass it to 'run-command'.
* gnu/installer/newt/page.scm (edit-file): Likewise.
| Ludovic Courtès |
2020-02-12 | installer: Remove the cow-store overlay after system installation....Fixes <https://issues.guix.info/issue/39217>.
Fixes <https://issues.guix.info/issue/38447>.
* gnu/installer/final.scm (umount-cow-store): New procedure ...,
(install-system): ... used here, to remove the store overlay so that the
target device is not seen as busy during further umount calls.
| Mathieu Othacehe |