diff options
| author | Felix Lechner <felix.lechner@lease-up.com> | 2023-03-20 21:25:41 -0700 |
|---|---|---|
| committer | Ludovic Courtès <ludo@gnu.org> | 2023-03-27 18:48:53 +0200 |
| commit | c9af27d4ca733b20f09019f1465d3e5fdc1ec724 (patch) | |
| tree | 00d781a58b7df2919d857d9f77cce7bd59fe1f74 | |
| parent | 38e7813c0358a829616c1748c975d1ebf709258d (diff) | |
| download | guix-c9af27d4ca733b20f09019f1465d3e5fdc1ec724.tar.gz guix-c9af27d4ca733b20f09019f1465d3e5fdc1ec724.zip | |
lint: Append "/info/refs" to git-reference-url.
For the atftp package added in the preceeding commit, lint produced this
warning:
gnu/packages/networking.scm:2924:5: atftp@0.8.0:
URI https://git.code.sf.net/p/atftp/code not reachable:
404 ("Not Found")
Thanks to Sergey Trofimov for suggesting a fix! [1]
[1] https://issues.guix.gnu.org/62156#3
It was implemented here, and the warning disappeared.
* guix/lint.scm (check-source): Append "/info/refs" to git-reference-url.
Co-authored-by: Sergey Trofimov <sarg@sarg.org.ru>
Signed-off-by: Ludovic Courtès <ludo@gnu.org>
| -rw-r--r-- | guix/lint.scm | 9 | ||||
| -rw-r--r-- | tests/lint.scm | 2 |
2 files changed, 9 insertions, 2 deletions
diff --git a/guix/lint.scm b/guix/lint.scm index 9eece374ff..3a93ba5325 100644 --- a/guix/lint.scm +++ b/guix/lint.scm @@ -1224,7 +1224,14 @@ password, provided REF's URI is HTTP or HTTPS." '()))) ((git-reference? (origin-uri origin)) (warnings-for-uris - (list (string->uri (git-reference-url (origin-uri origin)))))) + ;; for atftp, lint produced a warning: + ;; gnu/packages/networking.scm:2924:5: atftp@0.8.0: + ;; URI https://git.code.sf.net/p/atftp/code not reachable: + ;; 404 ("Not Found") + ;; fix from here: https://issues.guix.gnu.org/62156#3 + (list (string->uri (string-append + (git-reference-url (origin-uri origin)) + "/info/refs"))))) ((or (svn-reference? (origin-uri origin)) (svn-multi-reference? (origin-uri origin))) (let ((uri (svn-reference-uri-with-userinfo (origin-uri origin)))) diff --git a/tests/lint.scm b/tests/lint.scm index ce22e2355a..71e38550a1 100644 --- a/tests/lint.scm +++ b/tests/lint.scm @@ -1052,7 +1052,7 @@ (parameterize ((%http-server-port 0)) (with-http-server `((,redirect "")) (test-equal "source, git-reference: 301 -> 200" - (format #f "permanent redirect from ~a to ~a" + (format #f "permanent redirect from ~a/info/refs to ~a" (%local-url) initial-url) (let ((pkg (dummy-package "x" |